Fix warnings and apply suggestions. #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
force-pushed
the
fix-nullability-warnings
branch
from
11ae9b0
to
19b5bb9
Compare
jmarolf
reviewed
Aug 20, 2020
| @@ -11,7 +11,7 @@ | |||
| "/property:GenerateFullPaths=true", | |||
| "/consoleloggerparameters:NoSummary" | |||
| ], | |||
| "problemMatcher": "$msCompile" | |||
| "problemMatcher": [] | |||
There was a problem hiding this comment.
do you know what this change is about?
There was a problem hiding this comment.
I should have talk about this one. So OmniSharp will report diagnostics in the Problems tab. Running a build using a problems matcher will report build warnings and errors in the Problemss tab. This will duplicate warning and errors in the Problems tab amd the build reported problems won't go away until a new build is run. So, removing the problemMatcher will keep duplicate, zombie issues from entering the Problems tab.
jmarolf
approved these changes
Aug 20, 2020
JoeRobich
force-pushed
the
fix-nullability-warnings
branch
from
9263eea
to
cf18249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I locally updated the TFM to net5.0. I fixed the reported nullability warnings and applied the analyzer suggestions that were offered.