Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that file exists before considering it for formatting #775

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

JoeRobich
Copy link
Member

Resolves #671

@@ -197,7 +198,7 @@ private static Workspace OpenFolderWorkspace(string workspacePath, SourceFileMat
addedFilePaths.Add(document.FilePath);

var isFileIncluded = formatOptions.WorkspaceType == WorkspaceType.Folder ||
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documents in a folder workspace have already been verified to exist.

@JoeRobich JoeRobich merged commit 965e7e5 into dotnet:master Sep 8, 2020
@JoeRobich JoeRobich deleted the ensure-file-exists branch March 5, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnet-format creates empty files if non-existant file is given with charset
2 participants