-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some debug glitches #11981
Fix some debug glitches #11981
Conversation
Co-authored-by: Hadrian Tang <hadrianwttang@outlook.com>
I think this PR includes #11957 - so that one should should be merged first before this one. |
This is now ready. There's a separate issue for a case where the stepping on "when" patterns doesn't quite work with union patterns, see #11979, I'm going to look at that now but what we have in this PR is good to get in the bank. In addition to the adjusted baselines and new tests, I've been through all of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks straight-forward and good to me.
Just a minor comment on some code that I think was accidental.
I'll remove it in a separate PR |
I've been hunting for debug glitches and fixed a few:
This builds on #11957 so compare here dsyme/fsharp@bp5...dsyme:bp6
Baselines will need to be updated and some new debug testing added