Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some debug glitches #11981

Merged
merged 34 commits into from
Aug 18, 2021
Merged

Fix some debug glitches #11981

merged 34 commits into from
Aug 18, 2021

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Aug 16, 2021

@TIHan
Copy link
Contributor

TIHan commented Aug 17, 2021

I think this PR includes #11957 - so that one should should be merged first before this one.

@dsyme dsyme changed the title Fix some debug glitches [WIP] Fix some debug glitches Aug 17, 2021
@dsyme
Copy link
Contributor Author

dsyme commented Aug 18, 2021

This is now ready. There's a separate issue for a case where the stepping on "when" patterns doesn't quite work with union patterns, see #11979, I'm going to look at that now but what we have in this PR is good to get in the bank.

In addition to the adjusted baselines and new tests, I've been through all of tests\walkthroughs\DebugStepping\TheBigFileOfDebugStepping.fsx manually and apart from the one glitch above can't see any issues.

C:\GitHub\dsyme\fsharp>artifacts\bin\fsc\Debug\net472\fsc.exe -g --optimize- --tailcalls- --define:DEBUG tests\walkthroughs\DebugStepping\TheBigFileOfDebugStepping.fsx --langversion:preview
devenv /debugexe TheBigFileOfDebugStepping.exe

@TIHan TIHan changed the title [WIP] Fix some debug glitches Fix some debug glitches Aug 18, 2021
Copy link
Contributor

@TIHan TIHan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks straight-forward and good to me.

Just a minor comment on some code that I think was accidental.

@dsyme
Copy link
Contributor Author

dsyme commented Aug 18, 2021

Just a minor comment on some code that I think was accidental.

I'll remove it in a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Theme-Simple-F# A cross-community initiative called "Simple F#", keeping people in the sweet spot of the language.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants