Revert "Added CI job for deterministic builds" #12446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a847a71.
alfonsogarciacaro
added a commit
to alfonsogarciacaro/fsharp
that referenced
this pull request
Dec 26, 2021
* Adding 'refonly' command line option * Added a simple test, but it needs to fail * We need to emit two kinds of reference assemblies. one with optimizations and ones without * Passing reference assembly flag to IlxGen * Emit ReferenceAssemblyAttribute * Added ref-assembly rules for private and internal methods * use --refonly for now * Use HasFSharpAttribute * Added a failing test * Test passes * Trying to handle anonymous record types * Cleaning up. Using ILMemberAccess instead of Accessibility due to how the compiler understands Accessibility. * Using notlazy * Added another comment * Added mkDummyParameterVal * Using taccessPublic * More cleanup * Minor comment update * more cleanup * Adding FreeAnonRecdTypeInfos set * Adding options * Flowing free anonrecdtypeinfos * Fixing build * Tests pass. Able to emit partial ref assembly with anon recds * Minor rename * Added a failing test * Added failing test * Simpler handling of building lambdas * Trying to figure out default param names * Adding TryEmitReferenceAssembly * Moving some reference assembly generation rules to ilwrite * Fixing build * Added new compiler option '--refout:<file>' * Fixing one of the tests * refonly/refout should only be part of fsc * Updating help baseline * fixed build * Fixing build. Added basic deterministic test * Failing determinism test * Added DeterministicTests * Adding determinism task for CI * moving yml to pipelines * Trying to fix determinism CI * quick fix * removing job * Trying to fix ci * Removing this * Turn on determinism for build * Trying to fix * This works * Determinism * Building * Forgot to run test * Adding job * Trying to fix job * Remove job * Trying to figure out jobs * Updating job * Fixing determinism job * Fixing job * Update test-determinism.ps1 * Update FSharp.Profiles.props quick test to see if determinism CI breaks when deterministic flag is off, it should * Update test-determinism.ps1 * Update FSharpBuild.Directory.Build.props * Trying to fix build * Trying to fix build * fixing build * Fixing build * fixing build * Fixing build * Remove comment as it is not accurate * Removed generating metadata assembly for IDEs * Fixing build * Removing tests * Update ParseAndCheckInputs.fs * Update TypedTree.fs * Fixing build * Update TypedTreeOps.fs * Fixing build * Fixing build * Fixing build * Fixing build * Revert "Added CI job for deterministic builds" (dotnet#12446) This reverts commit a847a71. * Fix adding new opens when namespace declaration is on 1st line (dotnet#12443) * [main] Update dependencies from dotnet/arcade (dotnet#12450) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update Microsoft.FSharp.Targets (dotnet#12453) Add `WarningsNotAsErrors` to be forwarded to the compiler * [main] Update dependencies from dotnet/arcade (dotnet#12455) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20211126.2 (dotnet#12459) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21574.3 -> To Version 7.0.0-beta.21576.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 1487500 (dotnet#12461) * Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 1487500 * Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 1487500 * Update dependencies from https://github.com/dotnet/arcade build 20211126.4 (dotnet#12462) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21576.2 -> To Version 7.0.0-beta.21576.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Include range of attributes in SynExceptionDefnRepr, SynExceptionSig & SynModuleSigDecl.Exception. (dotnet#12441) * Disable auto-formatting by default + add an 'Experimental' suffix to the option (dotnet#12454) * Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 1489251 (dotnet#12468) * Fix compiler build when the username has a space (dotnet#12472) * Recognize IsByRefLikeAttribute from user code. (dotnet#11374) * Allow IsByRefLikeAttribute to be specified in user code or a non-framework assembly. And use isByrefLikeTyconRef instead of specifically checking whether the attribute is applied. A post-inference check about this attribute was moved to the aforementioned function. * Fix a typo. * Remove some leftover code that was causing errors. And use tname_IsByRefLikeAttribute without the TcGlobals qualification. * Handle the ILTypeSpec.Enclosing property correctly. It wasn't holding the namespace's components but the inner types if it was nested. The project now builds. * Test that custom IsByRefLikeAttributes are recognized. * Fix one failing test. * Fix another failing test. * Address PR feedback: move a check back to PostInferenceChecks.fs. * Add another test. * Remove three redundant package references from FSharp.Core. (dotnet#12479) * Add deterministic builds to the CI (dotnet#12451) Co-authored-by: Will Smith <lol.tihan@gmail.com> * Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 1499018 (dotnet#12492) * fixTests (dotnet#12490) * [main] Update dependencies from dotnet/arcade (dotnet#12483) * Update dependencies from https://github.com/dotnet/arcade build 20211202.3 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21576.4 -> To Version 7.0.0-beta.21602.3 * Update dependencies from https://github.com/dotnet/arcade build 20211203.6 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21576.4 -> To Version 7.0.0-beta.21603.6 * Update dependencies from https://github.com/dotnet/arcade build 20211206.6 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21576.4 -> To Version 7.0.0-beta.21606.6 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update baseline for fcs 'help' test * Added a test for '--refout', with outout and IL verification * Added tests to verify that static linking and refassemblies cannot be used together * Add mvid test for refonly + private members. It is failing on purpose, until MVID generation is fixed * WIP: Add some more to the tests * Added more tests for MVID * wip Co-authored-by: Will Smith <lol.tihan@gmail.com> Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Rodion Ivanov <rodion.ivanov999@gmail.com> Co-authored-by: dotnet bot <dotnet-bot@dotnetfoundation.org> Co-authored-by: Florian Verdonck <florian.verdonck@outlook.com> Co-authored-by: Ye <omppye@gmail.com> Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #12335, it seems to be failing in
main, gonna revert for now and investigate tomorrow.