Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add while! (while bang) #14238

Merged
merged 25 commits into from
Jul 26, 2023
Merged

Add while! (while bang) #14238

merged 25 commits into from
Jul 26, 2023

Conversation

kerams
Copy link
Contributor

@kerams kerams commented Nov 4, 2022

@kerams kerams requested a review from a team as a code owner November 4, 2022 18:47
@KevinRansom
Copy link
Member

This is nice, good work.

@vzarytovskii
Copy link
Member

How does it/will it behave in the resumable code?

Probably needs some tests/changes to the resumable intrinsics?

@kerams
Copy link
Contributor Author

kerams commented Nov 26, 2022

Added a test with a task CE, and other than the fact that it produces a warning saying it's not statically compilable, which I can do nothing about, it looks good.

@kerams
Copy link
Contributor Author

kerams commented Dec 5, 2022

One outstanding issue is the fact that there are multiple extraneous debug points on the guard condition. I don't quite understand how they're emitted since I thought I suppressed them all.

@vzarytovskii
Copy link
Member

I think @abonie is looking at sequence points generation. Might have an effect on this one as well?

@abonie
Copy link
Member

abonie commented Jul 21, 2023

At the moment I am only looking at #15289 as far sequence points go, but tbh can't repro it anywhere else

Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not entirely able to evaluate the changes in the parser core - but otherwise this looks good. Definitely worth bringing back to life, probably with some minimal docs (can be a followup).

Thanks for this! (and for removing some code dupes as well)

src/Compiler/pars.fsy Outdated Show resolved Hide resolved
src/Compiler/pars.fsy Outdated Show resolved Hide resolved
@psfinaki psfinaki mentioned this pull request Jun 6, 2024
2 tasks
@nojaf nojaf mentioned this pull request Jun 18, 2024
3 tasks
This was referenced Jun 29, 2024
@KevinRansom KevinRansom mentioned this pull request Aug 6, 2024
@jsoref jsoref mentioned this pull request Aug 21, 2024
3 tasks
@KevinRansom KevinRansom mentioned this pull request Sep 9, 2024
3 tasks
@mmitche mmitche mentioned this pull request Sep 11, 2024
3 tasks
@KevinRansom KevinRansom mentioned this pull request Oct 13, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

9 participants