-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add while! (while bang) #14238
Add while! (while bang) #14238
Conversation
This is nice, good work. |
tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncType.fs
Outdated
Show resolved
Hide resolved
How does it/will it behave in the resumable code? Probably needs some tests/changes to the resumable intrinsics? |
Added a test with a task CE, and other than the fact that it produces a warning saying it's not statically compilable, which I can do nothing about, it looks good. |
One outstanding issue is the fact that there are multiple extraneous debug points on the guard condition. I don't quite understand how they're emitted since I thought I suppressed them all. |
I think @abonie is looking at sequence points generation. Might have an effect on this one as well? |
At the moment I am only looking at #15289 as far sequence points go, but tbh can't repro it anywhere else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not entirely able to evaluate the changes in the parser core - but otherwise this looks good. Definitely worth bringing back to life, probably with some minimal docs (can be a followup).
Thanks for this! (and for removing some code dupes as well)
Implements fsharp/fslang-suggestions#1038.