Fix: Type checking behavior on interface extension members #14488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rosskuehl
changed the title
T-Gro
previously approved these changes
Dec 19, 2022
...ler.ComponentTests/Conformance/TypesAndTypeConstraints/IWSAMsAndSRTPs/IWSAMsAndSRTPsTests.fs
Show resolved
Hide resolved
rosskuehl
requested review from
T-Gro and
vzarytovskii
and removed request for
T-Gro and
vzarytovskii
vzarytovskii
approved these changes
Dec 19, 2022
psfinaki
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves fsharp/issues/14480
An FS3536 warning was being emitted for extension methods on interfaces without static abstract members (SAM). This was due to some of the
MethInfologic which classifies any method on an interface type to be an abstract method declaration or virtual dispatch slot. Adding an explicit extension member check to theCheckIWSAMfunction resolves the compiler warning issue.