-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Inline parameter hints for inner bindings #14506
Fix: Inline parameter hints for inner bindings #14506
Conversation
In PR's related to visual editor features, can we please have screenshot(s) ? Seeing the test, I think it also makes sense (separate to this PR!) to add common Fsharp.Core functions/arguments to a blacklist ;; "mapping" from Seq/List/Array.map being one of them. |
Thanks for the feedback @T-Gro! I added before & after screenshots to the description. |
We did just that in FSAC (after looking at the Rust-Analyzer decisions here) and tried to capture our heuristics: |
Fixes fsharp/issues/14501
By keeping track of long identifier ending positions for function calls, we can avoid recapturing parameters from the outer scope while traversing the syntax tree for hints.
There is likely a more efficient/direct way to patch this behavior, but this is a relatively simple change and appears to work as expected 👨🍳👍
Screenshots
Before
After