-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribute targets on records #17207
Attribute targets on records #17207
Conversation
❗ Release notes required
|
5131943
to
d43956f
Compare
Ready for review |
...nformance/BasicGrammarElements/CustomAttributes/AttributeUsage/E_AttributeTargetIsClass02.fs
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the RequireQualifiedAccess
reasoning here, maybe even in the comment as part of code?
Is it only a temporary need caused by new compiler + old FSharp.Core
combination, eventually to be removed?
Caution Repository is on lockdown for maintenance, all merges are on hold. |
@T-Gro So the check for Thanks for the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Appreciate your consistent and meticulous approach.
Do you see the light at the end of the attributes tunnel?
Yes. I have 2 more PRs and then a RFC |
Follow up: #17173
Records compiles down to a
class
orstruct
sharplab.This PR enforces the new rules on
records
.Old rules
New Rules
[<Struct>]
Before sharplab
After
Checklist