Improve completion after method/property override #17292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support static member override completion support get completions from generic base type for interface implementation and obj expr
support dotnet#16562 for C# style extension method
more type completion after colon override completion after `member` in interface or object expreesion interface name completion after `interface` class or interface name completion after `new` of object expression
format code
static thing completion show in short name
…ent-90/fsharp into completion-after-op-improve
❗ Release notes required
|
psfinaki
reviewed
Jun 10, 2024
psfinaki
reviewed
Jun 10, 2024
|
Thanks for this, looking forward to have this in the editor! Need to think a bit if this can have any perf traps or penalties, overall - good change and testing. |
Fix completion for same signature slot in different type/interface Fix parameter name generation Adjust code
psfinaki
reviewed
Jun 13, 2024
psfinaki
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
So there are quite a few FCS compiler changes here but I cannot see any potential dangers - at the same time, the new functionality is really cool.
@brianrourkeboll maybe you can also take a look at the FCS files, I think you've done some changes there recently.
LGTM, thanks!
|
Can't wait for this PR and the other completions-related PR to land so I can try them out in FSAC :) |
auduchinok
reviewed
Jun 17, 2024
|
(Converted to draft until the parser recovery is adjusted) |
vzarytovskii
approved these changes
Jun 26, 2024
This was referenced Jul 25, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve completion after method/property override.
Complete the parameter list of the overriden method and call base method or throw
NotImplementedExceptionComplete the parameter list of the overriden property and call base method or throw
NotImplementedExceptionCompletion list will exclude implemented members when triggered in an interface implementation, but not when triggered in an object expression (as cannot get the type of an obj expr from
GetExprTypingForPosition, it just returns the type of interface or the super class)newin object expressionFixes # (issue, if applicable)
Checklist