Add dependencies for System libraries that need to be lifted in the source-build / VMR context #17344
Conversation
Fixes dotnet/source-build#4477 Source-build doesn't require the MSBuild entries in Version.Details.xml anymore. Those were only added to enable prebuilt detection. Downgrading MSBuild to 17.8.3 and depend on the packages coming from SBRP instead of the previously built feed (N-1).
✅ No release notes required |
|
@ViktorHofer - What are you thinking for Preview 6? Should we patch this since we are getting late in the release cycle? |
I am passively following this as I ran into it in our CI. If you don't need to go through hoops to get this in preview 6 that would be nice. |
|
Downgrading and relying on SBRP doesn't work in this case as msbuild comes in transitively and as a preview version. I will instead add a Version.Details entry for SRM which should fix the downgrade issue. Yes, we should Patch this for P6. @MichaelSimons do we still have time for this? |
|
Hm. The issue with that is it'll likely start failing all of our VS CI, since we rely on newer msbuild there. Update: it is. What would be the guidance here? |
ViktorHofer
changed the title
ViktorHofer
changed the title
We can't release without it. |
|
Just successfully validated that this fixes the stage 2 build error described in the linked issue. @vzarytovskii can you please merge the PR? |
Fixes dotnet/source-build#4477
Source-build lifts the MSBuild package versions to the N-1 (previously produced assets) but fsharp pins the System.Reflection.Metadata (and similar System libs) version which is a transitive dependency to 8.0.0. That results in a package downgrade error. Define a dependency for System.Reflection.Metadata (and other System libs) so that source-build can lift that version as well.