Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor feature cleanup #17421

Merged
merged 10 commits into from
Jul 23, 2024
Merged

Minor feature cleanup #17421

merged 10 commits into from
Jul 23, 2024

Conversation

brianrourkeboll
Copy link
Contributor

@brianrourkeboll brianrourkeboll commented Jul 18, 2024 •
edited
Loading

Description

#17067 removed the calls to Array.map and List.map added in #16948 and replaced them with direct emission of loops.

Checklist

  • Release notes entry (N/A).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@brianrourkeboll brianrourkeboll marked this pull request as ready for review July 18, 2024 15:57
@brianrourkeboll brianrourkeboll requested a review from a team as a code owner July 18, 2024 15:57
@brianrourkeboll brianrourkeboll mentioned this pull request Jul 19, 2024
Merged
@psfinaki psfinaki added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Jul 22, 2024
@psfinaki
Copy link
Member

@brianrourkeboll thanks for keeping things tidy. You can probably remove the release notes here since those are internal changes, I added the label to suppress the release note gate.

psfinaki
psfinaki approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We'll merge this once .NET9 update is in.

@psfinaki psfinaki enabled auto-merge (squash) July 23, 2024 10:59
@brianrourkeboll
Copy link
Contributor Author

@psfinaki It looks like the CI stalled again :(

@psfinaki
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki psfinaki merged commit f8a5243 into dotnet:main Jul 23, 2024
30 checks passed
@brianrourkeboll brianrourkeboll deleted the feature-cleanup branch July 23, 2024 16:57
This was referenced Jul 31, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarfgp edgarfgp edgarfgp approved these changes

@psfinaki psfinaki psfinaki approved these changes

@KevinRansom KevinRansom KevinRansom approved these changes

Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brianrourkeboll @psfinaki @KevinRansom @edgarfgp