Span for .. in .. do optimization
#6213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TIHan
changed the title
for .. in .. do optimizationfor .. in .. do optimization
|
Make it snappy |
forki
approved these changes
Feb 8, 2019
|
This is almost done, trying to get tests to pass under .net core. |
dsyme
reviewed
Mar 11, 2019
| @@ -16,11 +16,6 @@ | |||
| <Compile Include="HashIfExpression.fs" /> | |||
| <Compile Include="ProductVersion.fs" /> | |||
| <Compile Include="EditDistance.fs" /> | |||
| <Compile Include="Compiler.fs" /> | |||
There was a problem hiding this comment.
Did you mean to remove these, or is this temporary? Thanks!
There was a problem hiding this comment.
Yes, I believe so. I moved these tests to FSharp.Tests.FSharpSuite instead.
|
This is ready I believe. |
TIHan
changed the title
for .. in .. do optimizationfor .. in .. do optimization
|
I would like to get this into master asap since it fixes tests as well. |
KevinRansom
reviewed
Apr 5, 2019
TIHan
commented
Apr 11, 2019
forki
reviewed
Apr 11, 2019
|
If tests pass, this should now be completely ready. |
|
This is really really ready. :) Just needs a review. |
KevinRansom
approved these changes
Apr 16, 2019
|
@dsyme, could you run your eyes over this one last time please. Thanks Kevin |
|
Reverted in #6558 due to a test failure. |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* Trying to optimize span in for loop * Added Span_GetItem call * Almost success with optimization * Fixed code gen * Added Span optimization tests * Added ReadOnlySpan opt * Cleaning up tests * Moving tests around * Trying to figure out span tests * Trying to fix some tests * Trying to get some more tests passing * Fixed range * Trying to get tests to pass again * Fixing tests for netcore * Fix build * When a solution becomes unloaded, we should clear F#'s cache (dotnet#6420) * Changing if directives * Simplifying * Using a type shape for span optimization * Fixing one test * Drastically simplified looking at the type shape for Span * Simplified a bit more * RunScript has expected error messages * Add back net472 * Feedback * Update SpanOptimizationTests.fs * Update SpanOptimizationTests.fs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves this issue: #6195
Optimizes
for .. in .. doon span types by using the indexer instead of the enumerator.Remaining work: