Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master to feature/and-bang #8247

Merged
merged 1 commit into from
Jan 18, 2020

Conversation

dotnet-bot
Copy link
Contributor

This is an automatically generated pull request from master into feature/and-bang.

git fetch --all
git checkout merges/master-to-feature/and-bang
git reset --hard upstream/feature/and-bang
git merge upstream/master
# Fix merge conflicts
git commit
git push upstream merges/master-to-feature/and-bang --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

* Rename `buff` to `writeViaBuffer` and remove `writeViaBufferWithEnvironmentNewLines`

`writeViaBufferWithEnvironmentNewLines` is causing borked output when error message ends with "\n".

This is probably dating from far back in the history of the codebase, and it doesn't show in windows console, probably because the console itself has some silly work around line termination...

* a bunch of .bsl updated with accurate output

* fix one bsl

* non change for CI

* non change for CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants