Oops - I should have reviewed the original pr better ... sorry #9881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
approved these changes
Aug 6, 2020
vzarytovskii
reviewed
Aug 6, 2020
| @@ -173,12 +173,12 @@ module rec Compiler = | |||
|
|
|||
| let withOptions (options: string list) (cUnit: CompilationUnit) : CompilationUnit = | |||
| match cUnit with | |||
| | FS fs -> FS { fs with Options = options } | |||
| | FS fs -> FS { fs with Options = fs.Options @ options } | |||
There was a problem hiding this comment.
Huh, I thought, I've fixed that. Thanks.
vzarytovskii
approved these changes
Aug 6, 2020
abelbraaksma
pushed a commit
to abelbraaksma/fsharp
that referenced
this pull request
Aug 9, 2020
…t#9881) * Fix Package Scripting nuget package * Compose * Phillip suggested options should compose too
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
…t#9881) * Fix Package Scripting nuget package * Compose * Phillip suggested options should compose too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow withPreview to compose on Options.