Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0.1xx] dotnet/runtime: Enable source-link in source-build for '.version' file #12527

Merged
merged 1 commit into from
Nov 11, 2021
Merged

[release/6.0.1xx] dotnet/runtime: Enable source-link in source-build for '.version' file #12527

merged 1 commit into from
Nov 11, 2021

Conversation

dagood
Copy link
Member

@dagood dagood commented Oct 26, 2021

@dagood dagood mentioned this pull request Oct 26, 2021
Closed
@dagood
Copy link
Member Author

dagood commented Oct 27, 2021

The runtime binlog shows the .version file being created, and there don't seem to be any adverse effects.

@dagood dagood marked this pull request as ready for review October 27, 2021 16:13
@dagood dagood requested a review from a team as a code owner October 27, 2021 16:13
@dagood dagood requested a review from eerhardt October 27, 2021 16:13
@eerhardt
Copy link
Member

If we aren't going to take this for 6.0.100, maybe we should make this change directly in dotnet/runtime?

@dagood
Copy link
Member Author

dagood commented Oct 27, 2021

True, good catch. Submitted: dotnet/runtime#60944

@dseefeld dseefeld merged commit 0527f05 into dotnet:release/6.0.1xx Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crummel crummel crummel approved these changes

@eerhardt eerhardt Awaiting requested review from eerhardt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dagood @eerhardt @crummel @dseefeld