Add KnownILLinkPack to bundled versions #15106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbomer
requested review from
LakshanF,
dsplaisted,
agocke,
marcpopMSFT and
vitek-karas
dsplaisted
approved these changes
Dec 9, 2022
| @@ -408,6 +409,10 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| ILCompilerRuntimeIdentifiers="@(ILCompilerSupportedRids, '%3B')" | |||
| /> | |||
|
|
|||
| <KnownILLinkPack Include="Microsoft.NET.ILLink.Tasks" | |||
| TargetFramework="net8.0" | |||
| ILLinkPackVersion="7.0.100-1.22606.1" /> | |||
There was a problem hiding this comment.
Is this version intended to be hard-coded until the linker moves into the runtime repo?
There was a problem hiding this comment.
Yeah, that's my intention. @tlakollo is working on building ILLink packages in dotnet/runtime so I think this will be possible soon. Until then I can bump it manually.
tlakollo
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of dotnet/linker#3029. With https://github.com/dotnet/sdk/pull/29441/files, this will enable the SDK to use a different version of illink depending on the TFM.
The latest 7.0 illink package is used when trimming net7.0 and earlier, which matches the configuration we shipped in the .NET 7 SDK.
These versions will quickly get out of date and need to be kept updated. For the latest (8.0) version I think it would be possible to set up dependency flow from linker -> installer to automate this, but I would rather wait for the linker move to dotnet/runtime, which will allow us to use
$(MicrosoftNETCoreAppRuntimePackageVersion)for the latest illink pack. (dotnet/linker#3153 will update this version number to begin with 8).Unfortunately the 7.0 version will still need manual updates. We might want to consider changing our version numbers to match dotnet/runtime, but AFAIK that will still be a manual process (to update the patch number in the release/7.0 branch of dotnet/linker every SDK servicing release).