PVP flow support #15267
Merged
PVP flow support #15267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ported changes from work done in the VMR. This change supports the ability to have PVP flow for source build. This means that repo builds only receive the versions of packages they actually have dependencies on. This setting may be enabled per repo in the repo projects via setting PackageVersionPropsFlowType to 'DependenciesOnly'. To support this, we need to make a few changes: - The previously source-built packages must be written per repo - The current source-built packages must be written per repo. - The build input props task must be updated to support the two flow types. Package version props creation has been changed to write a per-repo props file in all cases, even if there is no filtering. This required a bit of refactoring overall. However, when De0endenciesOnly is not enabled, build behavior not changed.
...ild/content/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.XPlat/WriteBuildInputProps.cs
Outdated
Show resolved
Hide resolved
...ild/content/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.XPlat/WriteBuildInputProps.cs
Outdated
Show resolved
Hide resolved
...ild/content/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.XPlat/WriteBuildInputProps.cs
Outdated
Show resolved
Hide resolved
...ild/content/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.XPlat/WriteBuildInputProps.cs
Outdated
Show resolved
Hide resolved
...ild/content/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.XPlat/WriteBuildInputProps.cs
Outdated
Show resolved
Hide resolved
...ild/content/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.XPlat/WriteBuildInputProps.cs
Outdated
Show resolved
Hide resolved
...ild/content/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.XPlat/WriteBuildInputProps.cs
Outdated
Show resolved
Hide resolved
...ild/content/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.XPlat/WriteBuildInputProps.cs
Outdated
Show resolved
Hide resolved
…eBuild.Tasks.XPlat/WriteBuildInputProps.cs Co-authored-by: Michael Simons <msimons@microsoft.com>
…eBuild.Tasks.XPlat/WriteBuildInputProps.cs Co-authored-by: Michael Simons <msimons@microsoft.com>
…eBuild.Tasks.XPlat/WriteBuildInputProps.cs Co-authored-by: Michael Simons <msimons@microsoft.com>
…eBuild.Tasks.XPlat/WriteBuildInputProps.cs Co-authored-by: Michael Simons <msimons@microsoft.com>
|
Responded to feedback. Confirmed that the output artifacts tarball still contains |
...content/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.XPlat/WritePackageVersionProps.cs
Outdated
Show resolved
Hide resolved
...content/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.XPlat/WritePackageVersionProps.cs
Outdated
Show resolved
Hide resolved
…eBuild.Tasks.XPlat/WritePackageVersionProps.cs Co-authored-by: Michael Simons <msimons@microsoft.com>
MichaelSimons
approved these changes
Jan 13, 2023
…eBuild.Tasks.XPlat/WritePackageVersionProps.cs Co-authored-by: Michael Simons <msimons@microsoft.com>
This was referenced Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported changes from work done in the VMR.
This change supports the ability to have PVP flow for source build. This means that repo builds only receive the versions of packages they actually have dependencies on. This setting may be enabled per repo in the repo projects via setting PackageVersionPropsFlowType to 'DependenciesOnly'.
To support this, we need to make a few changes:
Package version props creation has been changed to write a per-repo props file in all cases, even if there is no filtering. This required a bit of refactoring overall. However, when De0endenciesOnly is not enabled, build behavior not changed.