Add PackageDiff tool and task #18580
Conversation
src/SourceBuild/content/eng/tools/tasks/PackageDiff/PackageDiff/PackageDiff.csproj
Outdated
Show resolved
Hide resolved
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Library</OutputType> |
There was a problem hiding this comment.
| <OutputType>Library</OutputType> |
|
|
||
| <PropertyGroup> | ||
| <OutputType>Library</OutputType> | ||
| <TargetFrameworks>netstandard2.0</TargetFrameworks> |
There was a problem hiding this comment.
| <TargetFrameworks>netstandard2.0</TargetFrameworks> | |
| <TargetFramework>netstandard2.0</TargetFramework> |
…f/PackageDiff.csproj Co-authored-by: Michael Simons <msimons@microsoft.com>
| <TargetFrameworks>netstandard2.0</TargetFrameworks> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
| <IsPackable>true</IsPackable> |
There was a problem hiding this comment.
Do we need to create a package for the build task? Is the plan to use it directly here as part of the validation process? If so then we wouldn't need a package.
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> |
There was a problem hiding this comment.
I don't think that we need a CLI frontend. The MSBuild task should be enough. We don't have that for the other analysis types either (poison check, prebuilt check, etc.)
There was a problem hiding this comment.
Yeah, I had thought we needed the task to be netstandard2.0, which didn't have the reflection API's to get the assembly info. It looks like this task can be just netcurrent, so I can put everything in the task assembly and simplify this a bit.
There was a problem hiding this comment.
Yes, this doesn't need to support desktop msbuild.
…into PackageDiff
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Build.Utilities.Core" PrivateAssets="all" ExcludeAssets="Runtime" Version="$(MicrosoftBuildVersion)" /> |
There was a problem hiding this comment.
| <PackageReference Include="Microsoft.Build.Utilities.Core" PrivateAssets="all" ExcludeAssets="Runtime" Version="$(MicrosoftBuildVersion)" /> | |
| <PackageReference Include="Microsoft.Build.Utilities.Core" Version="$(MicrosoftBuildVersion)" /> |
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Build.Utilities.Core" PrivateAssets="all" ExcludeAssets="Runtime" Version="$(MicrosoftBuildVersion)" /> | ||
| </ItemGroup> | ||
| </Project> |
There was a problem hiding this comment.
| </Project> | |
| </Project> |
| } | ||
| } | ||
|
|
||
| public class GetClosestPackages: GetClosestPackageBase |
There was a problem hiding this comment.
Why not just have the task that accepts multiple packages and remove the singular one?
|
@jtschuster should this PR be closed? |
|
Yes, this should be closed, thanks for reminding me. |
Package Diff tool for dotnet/source-build#4051
Creates a command line tool and an msbuild tooltask to find differences in nuget packages. It does a git-style diffing to show line by line differences in the list of files in the package and in the nuspec file. There isn't yet a way to handle expected differences, so the msbuild task always succeeds, but will log any differences it finds.
I'm planning to do more in depth checks on each assembly in the packages and check for each member on each type and take a list of assemblies with expected differences to skip these checks.