Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable publishing in VMR #18917

Merged
merged 8 commits into from
Mar 15, 2024
Merged

Enable publishing in VMR #18917

merged 8 commits into from
Mar 15, 2024

Conversation

NikolaMilosavljevic
Copy link
Member

Contributes to dotnet/source-build#4101

Enables publishing in VMR.

Some highlights:

  • 10 patches for repo-specific changes including updates to arcade infra
  • significant updates in arcade infra, mostly refactoring several projects to enable source-building them, but also to enable publishing to local build storage
  • changes in 9 repos to enable proper publishing in VMR
  • updated sdk archive discovery path due to proper assets directory layout produced by publishing
  • to enable easy consumption of source-build artifacts, sdk archive gets copied to root of assets dir, next to symbols and PSB archives
  • sbrp packages cannot be published directly to reference packages directory, so they are published to temp location under obj, then copied to refrence dir, after previous sbrps are deleted
  • four new properties are passed to repo build to specify locations for artifacts, used by new task that publishes artifacts to local build storage

Patch backport PRs:

@NikolaMilosavljevic NikolaMilosavljevic requested review from a team as code owners March 8, 2024 00:06
@premun
Copy link
Member

premun commented Mar 11, 2024

Seems like there are still some issues similar to dotnet/arcade-services#3277

I will have a look

ViktorHofer
ViktorHofer reviewed Mar 11, 2024
View reviewed changes
eng/Publishing.props Outdated Show resolved Hide resolved
@premun premun mentioned this pull request Mar 11, 2024
Merged
3 tasks
@premun
Copy link
Member

premun commented Mar 11, 2024

Seems like there are still some issues similar to dotnet/arcade-services#3277

I will have a look

Fix is here: #18965
Once it merges, merge main here.

@ViktorHofer
Copy link
Member

@premun the sync is now failing in all legs

@NikolaMilosavljevic @ViktorHofer
Update src/redist/targets/GenerateLayout.targets
9e3874c 
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
@premun
Copy link
Member

premun commented Mar 12, 2024 •
edited
Loading

@premun the sync is now failing in all legs

These are just regular conflicts in the patches. The problem I was fixing is Windows only

ViktorHofer
ViktorHofer reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress 👍 Aside from the repo symbols archive discussions, the manifest location and a few nits, changes look good!

@NikolaMilosavljevic NikolaMilosavljevic mentioned this pull request Mar 13, 2024
Closed
@NikolaMilosavljevic
Copy link
Member Author

Arcade patch does not apply causing source-build and unified-build failures. I'll rebase the patch and update the PR later today when I push some more changes.

@NikolaMilosavljevic
Copy link
Member Author

@mmitche @ViktorHofer there are few more related (or dependent) PRs that might require updates or follow-up work, upon review. I'm mostly interested in runtime changes: dotnet/runtime#99432

This was referenced Mar 15, 2024
Merged
Closed
@ViktorHofer
Copy link
Member

#19049 is now failing. You might want to include the dependency update into this PR.

ViktorHofer
ViktorHofer approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some patches are old but it doesn't really matter as they will soon be removed.

@ViktorHofer ViktorHofer merged commit 3384a8d into dotnet:main Mar 15, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitche mmitche mmitche left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NikolaMilosavljevic @premun @ViktorHofer @mmitche