Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1ES templates - small cleanup #19104

Merged
merged 1 commit into from
Mar 20, 2024
Merged

1ES templates - small cleanup #19104

merged 1 commit into from
Mar 20, 2024

Conversation

MiYanni
Copy link
Member

@MiYanni MiYanni commented Mar 19, 2024 •
edited
Loading

Related: #19016

Summary

  • Allow template to switch to Unofficial when running a pull request.
    • This is used for internal code flow.
  • Remove component governance ignore folder parameter.
    • This is not necessary and was a misunderstanding of the tooling.
  • Remove custom build tags.
    • These were for tracking purposes of using the generation tooling. This repo did not use that tooling.

@MiYanni
Allow template to switch to Unofficial when running a pull request. R…
e12929e 
…emove component governance ignore folder parameter. Remove custom build tags.
@MiYanni MiYanni requested a review from a team March 19, 2024 21:54
nagilson
nagilson approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@nagilson nagilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart idea to condition the template this way. Nice!

@MiYanni MiYanni merged commit f3f5ce0 into dotnet:main Mar 20, 2024
22 checks passed
This was referenced Mar 21, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagilson nagilson nagilson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiYanni @nagilson