Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable CredScan #19159

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

MiYanni
Copy link
Member

@MiYanni MiYanni commented Mar 22, 2024

Summary

Our internal builds are failing after merging the 1ES PT migration PR. This is because the CredScan tool scans the MicroBuild signing plugin, which is installed by Arcade to do signing on our builds. Normally, the baselining files would have solved this issue. However, the MicroBuild/Plugins/nuget.config has dynamic content which causes the baselining to produce a new signature hash, and thus cannot be baselined. For the time being, we'll just disable CredScan until either:

  1. Arcade is updated to use the new version of the MicroBuild plugin, where it has been adjusted to install these files into a temporary location.
  2. We spent the effort to properly review the SDL tool settings, and set the scanning locations accordingly to not include these files.

I validated this works on a different branch also doing the 1ES PT migration:

@MiYanni MiYanni requested a review from a team March 22, 2024 22:01
@MiYanni MiYanni enabled auto-merge March 22, 2024 22:13
@MiYanni MiYanni merged commit ef7b033 into dotnet:main Mar 22, 2024
22 checks passed
@mmitche
Copy link
Member

mmitche commented Mar 25, 2024

MicroBuild got upgraded in arcade, so this can be reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants