Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy symbols to intermediates #19303

Merged
merged 4 commits into from
Apr 5, 2024
Merged

Copy symbols to intermediates #19303

merged 4 commits into from
Apr 5, 2024

Conversation

NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic NikolaMilosavljevic commented Apr 3, 2024 •
edited
Loading

Fixes: dotnet/source-build#4225
Fixes: dotnet/source-build#4288

Changes:

  • Remove infra related to symbols tarball from Publish.proj
  • Modify AfterSourceBuild.proj to copy symbols to intermediates
  • VMR orchestrator now passes additional property to repo build, for repo-specific symbols location in intermediates
  • Preserve symbols in intermediate location, to be used for conditioning targets in incremental build
  • Add 2 patches, for arcade and runtime. Will update their descriptions with backport comments once those PRs are out

@NikolaMilosavljevic NikolaMilosavljevic requested review from a team as code owners April 3, 2024 21:34
ViktorHofer
ViktorHofer approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Before merging, let's finish the discussion in the Arcade PR first though.

@ViktorHofer
Copy link
Member

This PR also fixes dotnet/source-build#4288, right?

@NikolaMilosavljevic
Copy link
Member Author

This PR also fixes dotnet/source-build#4288, right?

Yes, correct - I will update the PR description - thanks!

@NikolaMilosavljevic
Copy link
Member Author

Removed obsolete runtime patch - backport change has flown in.

ViktorHofer
ViktorHofer approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after you updated the arcade patch. Thanks for the work.

@NikolaMilosavljevic NikolaMilosavljevic merged commit 112c8f4 into dotnet:main Apr 5, 2024
22 checks passed
@ViktorHofer
Copy link
Member

The Arcade patch didn't get updated. Was that intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@NikolaMilosavljevic @ViktorHofer