-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable win-arm64 as known RID for AspNetCore #8173
Conversation
cc @tommcdon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed review, thank you for your patience.
@@ -108,7 +108,7 @@ | |||
<Crossgen2SupportedRids Include="linux-musl-x64;linux-x64;win-x64" /> | |||
|
|||
<AspNetCore31RuntimePackRids Include="@(AspNetCore30RuntimePackRids)" /> | |||
<AspNetCoreRuntimePackRids Include="@(AspNetCore31RuntimePackRids)" /> | |||
<AspNetCoreRuntimePackRids Include="@(AspNetCore31RuntimePackRids);win-arm64" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a supported RID for all versions or just 5.0+? Can we create another itemgroup to include this in and follow the pattern defined by AspNetCore30RuntimePackRids
and AspNetCore31RuntimePackRids
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for 5.0. Should this be renamed then to AspNetCore5.0RuntimePackRids
? It just seemed that the tip has the version-less element so I followed that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think creating a AspNetCore50RuntimePackRids
item group makes sense here.
@hoyosjs are you still working on this pr? |
@marcpopMSFT yes, although I was planning to merge it with the ARM64 PR I have coming up for the installers so it can be more easily ported to the release trains. Any opinions on that? |
What do you mean by "release trains"? RC2 is closing soon. You need to finish it before 9/24 to catch 5.0 release |
Closing in favor of #8470 |
No description provided.