Update ClockExtension to use the new magic command API (#3641)

* add support for hover text in magic commands

* prevent parsing of language service commands from sending RequestInput

* update ClockExtension to use the new magic command API

samples/extensions/ClockExtension/ClockExtension.csproj

@@ -15,8 +15,8 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="microsoft.dotnet.interactive" Version="1.0.0-beta.23562.1" />
-    <PackageReference Include="microsoft.dotnet.interactive.csharp" Version="1.0.0-beta.23562.1" />
+    <PackageReference Include="microsoft.dotnet.interactive" Version="1.0.0-beta.24475.1" />
+    <PackageReference Include="microsoft.dotnet.interactive.csharp" Version="1.0.0-beta.24475.1" />
   </ItemGroup>
 
   <ItemGroup>

samples/extensions/ClockExtension/ClockKernelExtension.cs

@@ -2,8 +2,9 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System;
-using System.CommandLine;
+using System.Threading.Tasks;
 using Microsoft.DotNet.Interactive;
+using Microsoft.DotNet.Interactive.Directives;
 using Microsoft.DotNet.Interactive.Formatting;
 using static Microsoft.DotNet.Interactive.Formatting.PocketViewTags;
 
@@ -19,27 +20,26 @@ public static void Load(Kernel kernel)
         Formatter.Register<DateTimeOffset>((date, writer) => writer.Write(date.DrawSvgClock()), "text/html");
 
         // Next, define a magic command that will render a clock.
-        var hourOption = new Option<int>(new[] { "-o", "--hour" },
-                                         "The position of the hour hand");
-        var minuteOption = new Option<int>(new[] { "-m", "--minute" },
-                                           "The position of the minute hand");
-        var secondOption = new Option<int>(new[] { "-s", "--second" },
-                                           "The position of the second hand");
-
-        var clockCommand = new Command("#!clock", "Displays a clock showing the current or specified time.")
+        var hourParameter = new KernelDirectiveParameter("--hour", "The position of the hour hand");
+        var minuteParameter = new KernelDirectiveParameter("--minute", "The position of the minute hand");
+        var secondParameter = new KernelDirectiveParameter("--second", "The position of the second hand");
+
+        var clockDirective = new KernelActionDirective("#!clock")
         {
-            hourOption,
-            minuteOption,
-            secondOption
+            Description = "Displays a clock showing the current or specified time.",
+            Parameters =
+            [
+                hourParameter,
+                minuteParameter,
+                secondParameter
+            ]
         };
 
-        clockCommand.SetHandler(
-            (hour, minute, second) => KernelInvocationContext.Current.Display(SvgClock.DrawSvgClock(hour, minute, second)),
-            hourOption,
-            minuteOption,
-            secondOption);
-
-        kernel.AddDirective(clockCommand);
+        kernel.AddDirective<DisplayClock>(clockDirective, (displayClock, context) =>
+        {
+            context.Display(SvgClock.DrawSvgClock(displayClock.Hour, displayClock.Minute, displayClock.Second));
+            return Task.CompletedTask;
+        });
 
         // Finally, display some information to the user so they can see how to use the extension.
         PocketView view = div(
@@ -49,9 +49,7 @@ public static void Load(Kernel kernel)
             " and ",
             code(typeof(DateTimeOffset)),
             ". Try it by running: ",
-            code("DateTime.Now"),
-            " or ",
-            code("#!clock -h")
+            code("DateTime.Now")
         );
 
         KernelInvocationContext.Current?.Display(view);

samples/extensions/ClockExtension/DisplayClock.cs

@@ -0,0 +1,10 @@
+using Microsoft.DotNet.Interactive.Commands;
+
+namespace ClockExtension;
+
+public class DisplayClock : KernelDirectiveCommand
+{
+    public int Hour { get; set; }
+    public int Minute { get; set; }
+    public int Second { get; set; }
+}

samples/extensions/SampleExtensions.Tests/ClockExtensionTests.cs

@@ -25,61 +25,48 @@ public ClockExtensionTests()
             };
 
             ClockKernelExtension.Load(_kernel);
-
-            KernelEvents = _kernel.KernelEvents.ToSubscribedList();
         }
 
-        public SubscribedList<KernelEvent> KernelEvents { get; }
-
         public void Dispose()
         {
             _kernel.Dispose();
-            KernelEvents.Dispose();
         }
 
         [Fact]
         public async Task It_formats_DateTime()
         {
-            using var events = _kernel.KernelEvents.ToSubscribedList();
+            var result = await _kernel.SubmitCodeAsync("DateTime.Now");
 
-            await _kernel.SubmitCodeAsync("DateTime.Now");
-
-            AssertThatClockWasRendered();
+            AssertThatClockWasRendered(result);
         }
 
         [Fact]
         public async Task It_formats_DateTimeOffset()
         {
-            using var events = _kernel.KernelEvents.ToSubscribedList();
-
-            await _kernel.SubmitCodeAsync("DateTimeOffset.Now");
+            var result = await _kernel.SubmitCodeAsync("DateTimeOffset.Now");
 
-            AssertThatClockWasRendered();
+            AssertThatClockWasRendered(result);
         }
 
         [Fact]
         public async Task It_adds_a_clock_magic_command()
         {
-            using var events = _kernel.KernelEvents.ToSubscribedList();
+            var result = await _kernel.SubmitCodeAsync("#!clock");
 
-            await _kernel.SubmitCodeAsync("#!clock");
-
-            AssertThatClockWasRendered();
+            AssertThatClockWasRendered(result);
         }
 
-        private void AssertThatClockWasRendered()
-        {
-            KernelEvents
-                .Should()
-                .ContainSingle<DisplayEvent>()
-                .Which
-                .FormattedValues
-                .Should()
-                .ContainSingle(v => v.MimeType == "text/html")
-                .Which
-                .Value
-                .Should()
-                .Contain("<circle");
-        }
+        private void AssertThatClockWasRendered(KernelCommandResult result) =>
+            result.Events
+                  .Should()
+                  .ContainSingle<DisplayEvent>()
+                  .Which
+                  .FormattedValues
+                  .Should()
+                  .ContainSingle(v => v.MimeType == "text/html")
+                  .Which
+                  .Value
+                  .Should()
+                  .Contain("<circle");
     }
 }

samples/extensions/SampleExtensions.Tests/SampleExtensions.Tests.csproj

@@ -11,8 +11,8 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="microsoft.dotnet.interactive.csharp" Version="1.0.0-beta.23562.1" />
-    <PackageReference Include="microsoft.dotnet.interactive.fsharp" Version="1.0.0-beta.23562.1" />
+    <PackageReference Include="microsoft.dotnet.interactive.csharp" Version="1.0.0-beta.24475.1" />
+    <PackageReference Include="microsoft.dotnet.interactive.fsharp" Version="1.0.0-beta.24475.1" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.10.0" />
     <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
     <PackageReference Include="xunit" Version="2.4.2" />

src/Microsoft.DotNet.Interactive.Tests/LanguageServices/HoverTextTests.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation and contributors. All rights reserved.
+// Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System.Threading.Tasks;

src/Microsoft.DotNet.Interactive/Parsing/SubmissionParser.cs

@@ -574,6 +574,7 @@ private async Task<ExpressionBindingResult> RequestMultipleInputsIfAppropriate(
         DirectiveExpressionNode expressionNode,
         string targetKernelName)
     {
+        // FIX: (RequestSingleValueFromKernel) make sure this is not dispatched on language service commands
         if (!(expressionNode
              .Ancestors()
              .OfType<DirectiveNode>()
@@ -628,6 +629,8 @@ sourceKernel is not null &&
         bool allowByRef,
         DirectiveExpressionNode expressionNode)
     {
+        // FIX: (RequestSingleValueFromKernel) make sure this is not dispatched on language service commands
+
         var requestValue = new RequestValue(sourceValueName, mimeType: mimeType, targetKernelName: sourceKernelName);
 
         var result = await destinationKernel.RootKernel.SendAsync(requestValue);