Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve diagnostic logging #2885

Closed
4 tasks done
shyamnamboodiripad opened this issue Apr 5, 2023 · 2 comments
Closed
4 tasks done

Improve diagnostic logging #2885

shyamnamboodiripad opened this issue Apr 5, 2023 · 2 comments
Labels
Area-Telemetry bug Something isn't working

Comments

@shyamnamboodiripad
Copy link
Contributor

shyamnamboodiripad commented Apr 5, 2023

  • Make sure we have exception handling in place to ensure that unhandled exceptions are at least logged (even when we swallow them to avoid a user-facing crash). Catch missing command/event registration in tests #2884 is an example of this.
  • Include routing slip information in the logs.
  • Several interesting fields on commands and events (such as TargetKernelName, OriginUri and DestinationUri) are missing in the logs. It would be great to log this information at least once for each command / event that is sent / received.
  • It may be nice to include logging for when commands are serialized deserialized on each side (i.e., in the sender and receiver). I think that would help us know what information is flowing over the wire even if this information were not being routed correctly to a particular kernel (or if there was some other crash that prevented this routing) ...
@shyamnamboodiripad
Copy link
Contributor Author

The following PRs have addressed most of the above tasks. The main remaining task is to ensure that all exceptions that we care about are captured in the logging.

#2996
#3001

@shyamnamboodiripad
Copy link
Contributor Author

Verified that exceptions are also being logged correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Telemetry bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants