Fix value sharing exception and deadlock #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
reviewed
Apr 5, 2023
| @@ -59,6 +59,7 @@ public static void RegisterDefaults() | |||
| { | |||
| _envelopeTypesByCommandTypeName = new ConcurrentDictionary<string, Type> | |||
| { | |||
| [nameof(AnonymousKernelCommand)] = typeof(KernelCommandEnvelope<AnonymousKernelCommand>), | |||
There was a problem hiding this comment.
This should not be in the list. AnonymousKernelCommand isn't intended to cross process boundaries and can't be correctly serialized. It's a shim to run arbitrary code on the scheduler inline with other commands.
jonsequitur
reviewed
Apr 5, 2023
| @@ -120,11 +120,38 @@ public async Task it_can_create_a_proxy_kernel_to_more_than_one_remote_subkernel | |||
| SupportedKernelCommands = fsharpKernelInfo.SupportedKernelCommands | |||
| }; | |||
|
|
|||
| const string installHttpKernel = | |||
| """ | |||
| #r "Microsoft.DotNet.Interactive.HttpRequest.dll" | |||
There was a problem hiding this comment.
This is unlikely to behave the way we expect it to in the context of the test project. We should discuss.
There was a problem hiding this comment.
This does seem to work (including in CI) :) But will discuss offline.
jonsequitur
reviewed
Apr 5, 2023
jonsequitur
reviewed
Apr 5, 2023
jonsequitur
reviewed
Apr 5, 2023
jonsequitur
reviewed
Apr 5, 2023
…n by default. This fixes a deadlock + exception.
shyamnamboodiripad
force-pushed
the
fixvaluesharing
branch
from
264766d
to
95541a3
Compare
jonsequitur
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.