remove custom .ipynb handling and update apis #1295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all custom Jupyter/.ipynb handling. The default new notebook is still .ipynb until microsoft/vscode#121974 is fixed, but then we'll default to .dib.
Scenarios to validate in Insiders:
.ipynb
; our controller should be selected and cell languages should be correct. Our controller is properly selected based on our specified affinity, but due to onDidChangeNotebookAssociation not fired on initial notebook open microsoft/vscode#121904 the cell languages aren't yet correct. There is currently no workaround..dib
; everything should work as before. This is good.