Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce object model for http requests and responses #2950

Merged
merged 3 commits into from
Apr 28, 2023

Conversation

shyamnamboodiripad
Copy link
Contributor

No description provided.

@AbhitejJohn
Copy link
Contributor

Curious, how would this object model be consumed externally? Trying to understand our extensibility layer and where this fits in.

@colombod
Copy link
Member

Curious, how would this object model be consumed externally? Trying to understand our extensibility layer and where this fits in.

The motivation is not sharing these types by reference (#!set assumes json serialization and we are out of proc anyway). this approach makes it safe to retain and support named requests and value sharing at any time without risks with the async operation and disposable streams.

@shyamnamboodiripad
Copy link
Contributor Author

@AbhitejJohn This essentially makes it possible to register a custom formatter based on the (now 'static') object model. And as Diego mentioned, this will also form the basis for implementing scenarios like named requests (which is part of the REST client's spec) in the future.

@colombod colombod added the Area-Formatting Data and object formatting as HTML and plaintext label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Formatting Data and object formatting as HTML and plaintext
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants