More logging improvements.

src/Microsoft.DotNet.Interactive/KernelCommandExtensions.cs

@@ -12,24 +12,30 @@ internal static class KernelCommandExtensions
     internal static void StampRoutingSlipAndLog(this KernelCommand command, Uri uri)
     {
         command.RoutingSlip.Stamp(uri);
-        Logger.Log.RoutingSlipInfo(command);
+        Logger.Log.RoutingSlipInfo(command, uri);
     }
 
     internal static void StampRoutingSlipAsAndLog(this KernelCommand command, Uri uri, string tag)
     {
         command.RoutingSlip.StampAs(uri, tag);
-        Logger.Log.RoutingSlipInfo(command);
+        Logger.Log.RoutingSlipInfo(command, uri, tag);
     }
 
     internal static void StampRoutingSlipAsArrivedAndLog(this KernelCommand command, Uri uri)
     {
         command.RoutingSlip.StampAsArrived(uri);
-        Logger.Log.RoutingSlipInfo(command);
+        Logger.Log.RoutingSlipInfo(command, uri, tag: "arrived");
     }
 
-    private static void RoutingSlipInfo(this Logger logger, KernelCommand command) =>
-        logger.Info(
-            "➡️ {0} {1}",
-            command.GetType().Name,
-            command.RoutingSlip);
+    private static void RoutingSlipInfo(this Logger logger, KernelCommand command, Uri uri, string tag = null)
+    {
+        if (string.IsNullOrEmpty(tag))
+        {
+            logger.Info("➡️ {0} {1}", command.GetType().Name, uri.ToString());
+        }
+        else
+        {
+            logger.Info("➡️ {0} {1} ({2})", command.GetType().Name, uri.ToString(), tag);
+        }
+    }
 }

src/Microsoft.DotNet.Interactive/KernelEventExtensions.cs

@@ -65,13 +65,25 @@ private static IReadOnlyCollection<Diagnostic> RemapDiagnosticsFromLanguageNode(
 
     internal static void StampRoutingSlipAndLog(this KernelEvent @event, Uri uri)
     {
+        if (@event.RoutingSlip.Count == 0)
+        {
+            // Log detailed event info if this is the first time the routing slip is being updated.
+            Logger.Log.Info("{event}", @event);
+        }
+
         @event.RoutingSlip.Stamp(uri);
-        Logger.Log.RoutingSlipInfo(@event);
+        Logger.Log.RoutingSlipInfo(@event, uri);
     }
 
-    private static void RoutingSlipInfo(this Logger logger, KernelEvent @event) =>
-        logger.Info(
-            "⬅️ {0} {1}",
-            @event.GetType().Name,
-            @event.RoutingSlip);
+    private static void RoutingSlipInfo(this Logger logger, KernelEvent @event, Uri uri, string tag = null)
+    {
+        if (string.IsNullOrEmpty(tag))
+        {
+            logger.Info("⬅️ {0} {1}", @event.GetType().Name, uri.ToString());
+        }
+        else
+        {
+            logger.Info("⬅️ {0} {1} ({2})", @event.GetType().Name, uri.ToString(), tag);
+        }
+    }
 }

src/Microsoft.DotNet.Interactive/KernelInvocationContext.cs

@@ -39,10 +39,6 @@ private KernelInvocationContext(KernelCommand command)
     {
         var operation = new OperationLogger(
             args: new object[] { command },
-            exitArgs: () => new[]
-            {
-                (nameof(KernelCommand), (object)command)
-            },
             category: nameof(KernelInvocationContext),
             logOnStart: true);
 

src/dotnet-interactive/CommandLine/CommandLineParser.cs

@@ -514,11 +514,6 @@ private static CompositeKernel CreateKernel(
             .AddConnectionOptions(new JupyterHttpKernelConnectionOptions())
             .AddConnectionOptions(new JupyterLocalKernelConnectionOptions()));
 
-        if (startupOptions.Verbose)
-        {
-            kernel.LogEventsToPocketLogger();
-        }
-
         SetUpFormatters(frontendEnvironment);
 
         kernel.DefaultKernelName = defaultKernelName;

src/dotnet-interactive/Pocket/Format.CustomizeLogString.cs

@@ -153,10 +153,6 @@ private static void AppendLogString(this TextWriter writer, KernelEvent @event)
                 writer.Write(completionsProduced.LinePositionSpan?.ToString());
                 break;
 
-            case DiagnosticLogEntryProduced diagnosticLogEntryProduced:
-                writer.Write(diagnosticLogEntryProduced.Message.TruncateForDisplay());
-                break;
-
             case DiagnosticsProduced diagnosticsProduced:
                 var diagnostics = diagnosticsProduced.Diagnostics;
                 if (diagnostics.Any()) // TODO: How come we produce empty DiagnosticsProduced events?
@@ -199,8 +195,51 @@ private static void AppendLogString(this TextWriter writer, KernelEvent @event)
                 writer.Write(inputProduced.Value.TruncateForDisplay());
                 break;
 
+            case KernelInfoProduced kernelInfoProduced:
+                writer.AppendProperties(
+                    (nameof(kernelInfoProduced.KernelInfo.LocalName), kernelInfoProduced.KernelInfo.LocalName),
+                    (nameof(kernelInfoProduced.KernelInfo.Uri), kernelInfoProduced.KernelInfo.Uri.ToString()),
+                    (nameof(kernelInfoProduced.KernelInfo.IsComposite), kernelInfoProduced.KernelInfo.IsComposite.ToString()),
+                    (nameof(kernelInfoProduced.KernelInfo.IsProxy), kernelInfoProduced.KernelInfo.IsProxy.ToString()),
+                    (nameof(kernelInfoProduced.KernelInfo.RemoteUri), kernelInfoProduced.KernelInfo.RemoteUri?.ToString()));
+                break;
+
+            case KernelReady kernelReady:
+                writer.Write('(');
+                writer.Write(kernelReady.KernelInfos.Length);
+                writer.Write(" Kernels)");
+                break;
+
             case PackageAdded packageAdded:
-                writer.Write(packageAdded.PackageReference);
+                writer.Write(packageAdded.PackageReference.ToString());
+                break;
+
+            case SignatureHelpProduced signatureHelpProduced:
+                writer.Write('(');
+                writer.Write(signatureHelpProduced.Signatures?.Count ?? 0);
+                writer.Write(" Signatures)");
+                writer.AppendProperties(
+                    (nameof(signatureHelpProduced.ActiveSignatureIndex), signatureHelpProduced.ActiveSignatureIndex.ToString()),
+                    (nameof(signatureHelpProduced.ActiveParameterIndex), signatureHelpProduced.ActiveParameterIndex.ToString()));
+                break;
+
+            case ValueInfosProduced valueInfosProduced:
+                writer.Write('(');
+                writer.Write(valueInfosProduced.ValueInfos.Count);
+                writer.Write(" Values)");
+                break;
+
+            case ValueProduced valueProduced:
+                writer.Write(valueProduced.Name);
+                writer.Write(" '");
+                writer.Write(valueProduced.FormattedValue.Value.TruncateForDisplay());
+                writer.Write("' (");
+                writer.Write(valueProduced.FormattedValue.MimeType);
+                writer.Write(')');
+                break;
+
+            case WorkingDirectoryChanged workingDirectoryChanged:
+                writer.Write(workingDirectoryChanged.WorkingDirectory.TruncateForDisplay());
                 break;
 
             // Base event types.