use PasswordString object #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colombod
added
the
Area-Formatting
colombod
commented
Sep 19, 2023
| @@ -1,8 +1,13 @@ | |||
| // Copyright (c) .NET Foundation and contributors. All rights reserved. | |||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | |||
|
|
|||
| using Microsoft.DotNet.Interactive.Formatting; | |||
jonsequitur
reviewed
Sep 19, 2023
|
|
||
| namespace Microsoft.DotNet.Interactive; | ||
|
|
||
| internal class PasswordStringFormatterSource : ITypeFormatterSource |
There was a problem hiding this comment.
This seems more complex than needed. A custom ToString should work fine.
colombod
commented
Sep 19, 2023
|
|
||
| namespace Microsoft.DotNet.Interactive; | ||
|
|
||
| internal class PasswordStringFormatterSource : ITypeFormatterSource |
colombod
force-pushed
the
password_strings
branch
7 times, most recently
from
e1ffac3 to
b5ddd57
Compare
align api for poweshell update test for new formatting simplify pr
colombod
force-pushed
the
password_strings
branch
from
b5ddd57 to
6b79f22
Compare
colombod
force-pushed
the
password_strings
branch
from
9324645 to
f16e6d1
Compare
shyamnamboodiripad
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using PasswordString object in GetPAsswordGesture to prevent printing password values in clear