Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-target Microsoft.DotNet.Interactive.csproj to support both netstandard2.0 as well as net8.0 #3246

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

shyamnamboodiripad
Copy link
Contributor

@shyamnamboodiripad shyamnamboodiripad commented Oct 11, 2023

Also includes the following related changes:

  • Remove Microsoft.DotNet.Interactive.VisualStudio.csproj now that Microsoft.DotNet.Interactive.csproj itself supports netstandard2.0.
  • Rename Microsoft.DotNet.Interactive.VisualStudio.Tests.csproj to Microsoft.DotNet.Interactive.NetFramework.Tests.csproj.
  • Move StdIoKernelConnector from dotnet-interactive.csproj into Microsoft.DotNet.Interactive.csproj.
  • Include some additional tests related to ProxyKernel in Microsoft.DotNet.Interactive.NetFramework.Tests.csproj.

@shyamnamboodiripad shyamnamboodiripad changed the title Multi-target Microsoft.DotNet.Interactive.csproj to support both netstandard2.0 as well as net7.0 Multi-target Microsoft.DotNet.Interactive.csproj to support both netstandard2.0 as well as net8.0 Nov 25, 2023
…tandard2.0 as well as net8.0.

Also includes the following changes:

* Remove Microsoft.DotNet.Interactive.VisualStudio.csproj now that Microsoft.DotNet.Interactive.csproj itself supports netstandard2.0.
* Rename Microsoft.DotNet.Interactive.VisualStudio.Tests.csproj to Microsoft.DotNet.Interactive.NetFramework.Tests.csproj.
* Move StdIoKernelConnector from dotnet-interactive.csproj into Microsoft.DotNet.Interactive.csproj.
* Include some additional tests related to ProxyKernel in Microsoft.DotNet.Interactive.NetFramework.Tests.csproj.
@shyamnamboodiripad shyamnamboodiripad merged commit a751821 into dotnet:main Nov 28, 2023
4 checks passed
@shyamnamboodiripad shyamnamboodiripad deleted the multitarget branch November 28, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants