Upgrade F# language version for 8.0 #3392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @kojo12228! This is a good catch. The change you made doesn't affect the actual language version but it affects the language version that these two kernels advertise. There's probably a way (such as a test) to better keep these in sync in the future. It incidentally caused one of the contract tests to fail. This value should probably not be in the constructor for |
jonsequitur
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update another reference to C# language to 12 (the other one being amended in #3338).
Because the language version in compiler args is
previewanyway, this doesn't matter too much (although it did surprise me that it was set to preview).