improve Prebuild parallelizability #3523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
force-pushed
the
improve-Prebuild-parallelizability
branch
from
517833d
to
8279638
Compare
jonsequitur
force-pushed
the
improve-Prebuild-parallelizability
branch
from
8279638
to
4ccc721
Compare
AbhitejJohn
approved these changes
Apr 17, 2024
jonsequitur
added
Area-Try .NET
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dotnet trycompilation process was focused on single-user local execution while Try .NET's was focused on multiple concurrent users. These changes adjust the behaviors toward the latter, reducing mutability side-effects by handing out a newWorkspacefor each operation instead of attempting to reuse them.Some performance regression is likely here, which I'll address in a later PR.