Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish DiagnosticsProduced even when there are no diagnostics #3531

Conversation

jonsequitur
Copy link
Contributor

This fixes dotnet/try#1173

@jonsequitur jonsequitur enabled auto-merge (rebase) April 24, 2024 19:25
@jonsequitur jonsequitur force-pushed the publish-DiagnosticsProduced-when-no-diagnostics branch from e0ea599 to 389b3e8 Compare April 24, 2024 19:36
@jonsequitur jonsequitur force-pushed the publish-DiagnosticsProduced-when-no-diagnostics branch from 389b3e8 to 190b36c Compare April 24, 2024 20:29
@colombod
Copy link
Member

SinguatureHelp, HoverText and Completions needs to be changed too.

@jonsequitur jonsequitur merged commit 4d7051e into dotnet:main Apr 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

diagnostics are not cleared when editor is empty
2 participants