improve magic command completions #3700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyamnamboodiripad
approved these changes
Oct 7, 2024
| return subcommandCompletions.Concat(baseCompletions).ToArray(); | ||
| completions.AddRange(subcommandCompletions); | ||
|
|
||
| if (Parent is KernelDirective parent) |
There was a problem hiding this comment.
Does order in which the completions are added to the list matter? If yes, should the directive-based ones be added first?
There was a problem hiding this comment.
It doesn't matter. At this level, the final list hasn't been assembled, so ordering doesn't matter yet, nor does e.g. filtering for partially-typed completions.
|
|
||
| case DirectiveNameNode nameNode when subcommandNode is not null: | ||
| subcommandNode.Add(nameNode); | ||
| case DirectiveParameterNode parameterNode when subcommandNode is null: |
There was a problem hiding this comment.
Is this a duplicate of the case on line 188 above?
There was a problem hiding this comment.
It is! Nice catch.
jonsequitur
added
Area-Submission Parsing & Magic Commands
and removed
Area-Language Services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of cases with magic command completions.