Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master build is broken after Version updates #1940

Closed
pgrawehr opened this issue Oct 2, 2022 · 2 comments · Fixed by #1942
Closed

Master build is broken after Version updates #1940

pgrawehr opened this issue Oct 2, 2022 · 2 comments · Fixed by #1942
Assignees
Labels
bug Something isn't working Priority:0 Work that we can't release without untriaged

Comments

@pgrawehr
Copy link
Contributor

pgrawehr commented Oct 2, 2022

Describe the bug

Running build -pack on current master results in these errors:

C:\projects\iot\.dotnet\sdk\7.0.100-rc.1.22431.12\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(203,
6): error : Für dieses Projekt kann kein Paket erstellt werden, weil die Paketerstellung deaktiviert wurde. Fügen Sie d
er Projektdatei <IsPackable>true</IsPackable> hinzu, um die Erstellung eines Pakets aus diesem Projekt zu ermöglichen.
[C:\projects\iot\src\devices\Media\VideoDevice\samples\MjpegStream\MjpegStream.csproj]
C:\projects\iot\.dotnet\sdk\7.0.100-rc.1.22431.12\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(221,
5): error NU5104: Eine stabile Version eines Pakets darf keine Abhängigkeit mit einem Vorabrelease aufweisen. Ändern Si
e entweder die Versionsspezifikation der abhängigen Komponente "System.Device.Gpio [2.3.0-dev, )", oder aktualisieren S
ie das Versionsfeld in der NUSPEC-Datei. [C:\projects\iot\tools\ArduinoCsCompiler\samples\WeatherStation\WeatherStation
.csproj]
C:\projects\iot\.dotnet\sdk\7.0.100-rc.1.22431.12\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(221,
5): error NU5104: Eine stabile Version eines Pakets darf keine Abhängigkeit mit einem Vorabrelease aufweisen. Ändern Si
e entweder die Versionsspezifikation der abhängigen Komponente "System.Device.Gpio [2.3.0-dev, )", oder aktualisieren S
ie das Versionsfeld in der NUSPEC-Datei. [C:\projects\iot\tools\ArduinoCsCompiler\ArduinoCsCompiler.csproj]
C:\projects\iot\.dotnet\sdk\7.0.100-rc.1.22431.12\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(221,
5): error NU5104: Eine stabile Version eines Pakets darf keine Abhängigkeit mit einem Vorabrelease aufweisen. Ändern Si
e entweder die Versionsspezifikation der abhängigen Komponente "System.Device.Gpio [2.3.0-dev, )", oder aktualisieren S
ie das Versionsfeld in der NUSPEC-Datei. [C:\projects\iot\tools\ArduinoCsCompiler\samples\BlinkingLed\BlinkingLed.cspro
j]

As a follow-up, build -pack /p:GenerateCompatibilitySuppressionFile=true doesn't work and I can't update the suppression file (there are some expected breakages in a pending PR)

Steps to reproduce

Run

git clean -dfx
build -pack

Expected behavior
No errors

Actual behavior
Build fails
Versions used
Main branch from 2022-09-30, revision d7f6c14

CC: @joperezr

@pgrawehr pgrawehr added bug Something isn't working Priority:0 Work that we can't release without labels Oct 2, 2022
@ghost ghost added the untriaged label Oct 2, 2022
@joperezr joperezr self-assigned this Oct 3, 2022
@joperezr
Copy link
Member

joperezr commented Oct 3, 2022

You are right, thanks for logging this @pgrawehr. Seems like a problem with my recent changes to make the build faster. I'm working on a fix and will push a PR in a sec that should fix it.

@joperezr
Copy link
Member

joperezr commented Oct 4, 2022

FWIW, the reason why this wasn't broken in CI and builds still worked after that change, was because our CI and official builds don't use the -pack argument, instead call build.cmd /p:BuildPackages=true. In any case, after the changes here, things should start to work again when using the -pack argument.

@ghost ghost added the Status: Fixed label Oct 4, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Priority:0 Work that we can't release without untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants