Fix build issue when trying to run pack #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrawehr
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Thanks, that indeed fixes it.
It's a bit ugly that our build is not really controlled by the default arguments to build.cmd. Many of the arguments specified in build /? don't work as expected (e.g. -test is ignored, because the tests always run), and other important ones are properties and therefore not documented.
|
Yup, that is a valid concern. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1940
cc: @pgrawehr
Microsoft Reviewers: Open in CodeFlow