Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find correct links for suppressed erroronous links #1972

Closed
krwq opened this issue Nov 2, 2022 · 4 comments
Closed

Find correct links for suppressed erroronous links #1972

krwq opened this issue Nov 2, 2022 · 4 comments
Labels
bug Something isn't working Priority:1 Work that is critical for the release, but we could probably ship without

Comments

@krwq
Copy link
Member

krwq commented Nov 2, 2022

#1970 has fixed majority of the problems with links however there are couple of them left.

Currently https://github.com/dotnet/iot/blob/main/.markdown-link-check.json contains the suppressions. Among them:

It would be good to figure out how do we make sure datasheets are up to date? Straight forward options:

  • update link whenever it gets old
  • create a copy in our repo (can we even do that?)

given amount of the updates in the PR referenced above it doesn't seem uncommon for links to get out of date.

cc: @Jimmys20

@krwq krwq added the bug Something isn't working label Nov 2, 2022
@ghost ghost added the untriaged label Nov 2, 2022
@Jimmys20
Copy link
Contributor

Jimmys20 commented Nov 2, 2022

Just a few notes about some links:

@Jimmys20
Copy link
Contributor

Jimmys20 commented Nov 3, 2022

Is it possible that the automatic check should be applied to this file:

npm install -g markdownlint-cli
instead of .vsts-ci.yml? Or maybe to both files? I'm not sure if it is working, can anyone confirm?

@krwq
Copy link
Member Author

krwq commented Nov 3, 2022

I also did not see the automatic check in PR yet but we didn't have any new PR yet so I wasn't sure if that's by design or not. I didn't notice there was another file so I think both sounds good (let's just follow pattern we already have) - if we should remove one of the files let's do it separately

@krwq krwq added Priority:1 Work that is critical for the release, but we could probably ship without and removed untriaged labels Nov 3, 2022
@krwq
Copy link
Member Author

krwq commented Mar 16, 2023

[Triage] this is not a pain point anymore so closing.

@krwq krwq closed this as completed Mar 16, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Priority:1 Work that is critical for the release, but we could probably ship without
Projects
None yet
Development

No branches or pull requests

2 participants