-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added automatic markdown link checking and fixed broken links #1970
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, +1 if you make our build break whenever there is any broken link. Possibly markdownlint has option for that: https://github.com/dotnet/iot/blob/main/.vsts-ci.yml#L107
You can use something similar to this to run it on all files:
There are plenty of other dead links in the repo. Probably some configuration will be needed as well to ignore some of the bad links (some require authentication) |
This is the list of the problematic links according to markdown-link-check that I wasn't sure how to fix:
Certain paths can be ignored by adding the appropriate pattern to
|
@Jimmys20 I'll suggest create that config file and add each link with missing datasheet or similar (outside of our repo) individually and fix it separately outside of this PR. Once you're done let's open issue and point to that ignore file that those datasheets are missing and let's figure out path forward (possibly we should be copying those datasheets into our repo, not sure but we should figure out generic solution). In this PR let's focus on enabling the automatic checks and make sure links within the repo are correct. If you can find alternative link to datasheet that's fine too 😄 But I think we should open issue anyway because eventually another external link will go 404 and we'll be in the same spot so we should figure out what to do in those situations |
.mlc-config.json
Outdated
@@ -0,0 +1,4 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll suggest to match naming with: https://github.com/dotnet/iot/blob/main/.markdownlint.json
so something like .markdown-link-checker.json
Should the CI be showing link checker errors? I'm not seeing any (or did you fix all of the issues 👀) Possibly it will show only after merging |
The last broken links within repo are in https://github.com/dotnet/iot/blob/main/samples/bmp280-sensor-azure-iot-hub/Readme.md: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File an issue on the patterns we had to add to suppress errors and assuming there is no more errors LGTM and thank you for the effort!
Thanks again @Jimmys20! I'll file an issue shortly |
Fixes #1969
This PR enables automatic markdown link checking using markdown-link-check utility. I fixed most of the broken links and I created an ignore list for the links I wasn't sure how to fix.
Microsoft Reviewers: Open in CodeFlow