Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of VL53L1X sensor including sample and documentation #1923

Merged
merged 5 commits into from
Oct 4, 2022
Merged

Implementation of VL53L1X sensor including sample and documentation #1923

merged 5 commits into from
Oct 4, 2022

Conversation

sichelz1
Copy link
Contributor

@sichelz1 sichelz1 commented Sep 8, 2022 •
edited by ghost
Loading

null

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-device-bindings Device Bindings for audio, sensor, motor, and display hardware that can used with System.Device.Gpio label Sep 8, 2022
@dnfadmin
Copy link

dnfadmin commented Sep 8, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

Ellerbach
Ellerbach reviewed Sep 9, 2022
View reviewed changes
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition, some feedback regarding our pattern especially for I2cDevice and GpioController. Plus some comments to simplify the methods

src/devices/Device-Index.md Outdated Show resolved Hide resolved
src/devices/README.md Outdated Show resolved Hide resolved
src/devices/Vl53L1X/DistanceMode.cs Outdated Show resolved Hide resolved
src/devices/Vl53L1X/TimingBudget.cs Outdated Show resolved Hide resolved
src/devices/Vl53L1X/Vl53L1X.cs Outdated Show resolved Hide resolved
src/devices/Vl53L1X/Vl53L1X.cs Outdated Show resolved Hide resolved
src/devices/Vl53L1X/Vl53L1X.cs Outdated Show resolved Hide resolved
src/devices/Vl53L1X/Vl53L1X.cs Outdated Show resolved Hide resolved
src/devices/Vl53L1X/samples/Vl53L1X.sample.csproj Show resolved Hide resolved
src/devices/Vl53L1X/Vl53L1X.cs Outdated Show resolved Hide resolved
@sichelz1
Removed links from md files
c9a2b7f 
Removed gpiocontroller from vl53l1x class
Passing I2cdevice to constructor
Switched from functions to properties
Ellerbach
Ellerbach reviewed Sep 14, 2022
View reviewed changes
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks great! Now it's about using UnitsNet for the distances so anyone can use their preferred one fully transparently. You'll find plenty of examples in the repo. And it's very straightforward to add.

src/devices/Vl53L1X/Vl53L1X.cs Outdated Show resolved Hide resolved
src/devices/Vl53L1X/Vl53L1X.cs Show resolved Hide resolved
src/devices/Vl53L1X/Vl53L1X.cs Show resolved Hide resolved
src/devices/Vl53L1X/Vl53L1X.cs Show resolved Hide resolved
src/devices/Vl53L1X/Vl53L1X.cs Show resolved Hide resolved
src/devices/Vl53L1X/Vl53L1X.cs Outdated Show resolved Hide resolved
src/devices/Vl53L1X/Vl53L1X.cs Outdated Show resolved Hide resolved
src/devices/Vl53L1X/Vl53L1X.cs Outdated Show resolved Hide resolved
src/devices/Vl53L1X/Vl53L1X.cs Outdated Show resolved Hide resolved
src/devices/Vl53L1X/Vl53L1X.cs Outdated Show resolved Hide resolved
Ellerbach
Ellerbach approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks really good! Approving as even without the few comments, it's good from my side. I let someone else to have a look as well

src/devices/Vl53L1X/Vl53L1X.cs Show resolved Hide resolved
src/devices/Vl53L1X/Vl53L1X.cs Show resolved Hide resolved
src/devices/Vl53L1X/Vl53L1X.cs Show resolved Hide resolved
src/devices/Vl53L1X/Vl53L1X.cs Show resolved Hide resolved
src/devices/Vl53L1X/Roi.cs Show resolved Hide resolved
src/devices/Vl53L1X/Vl53L1X.cs Show resolved Hide resolved
@pgrawehr
Copy link
Contributor

/azp run dotnet.iot

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Ellerbach
Copy link
Member

/azp run dotnet.iot

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Ellerbach Ellerbach merged commit 7dc2641 into dotnet:main Oct 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ellerbach Ellerbach Ellerbach approved these changes

Assignees

@krwq krwq

@Ellerbach Ellerbach

Labels
area-device-bindings Device Bindings for audio, sensor, motor, and display hardware that can used with System.Device.Gpio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sichelz1 @dnfadmin @pgrawehr @Ellerbach @krwq