-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made I2cDevice/SpiDevice ReadByte/WriteByte methods virtual #1937
Made I2cDevice/SpiDevice ReadByte/WriteByte methods virtual #1937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you
@Jimmys20 looks good thank you, I assume this will get merged soon but API changes to System.Device.Gpio require at least two people to approve so we'll need to wait for those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsafe should not be required for this method.
Sorry, I pressed "Re-request review" for gfoidl and it removed the other review requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is "limitation" of GH, that other reviewers (based on file-owners) get removed than.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Fixes #1629
Made
WriteByte
/ReadByte
methods virtual forI2cDevice
andSpiDevice
and removed the override methods from deriving classes that had same implementation as base methods.Microsoft Reviewers: Open in CodeFlow