-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hand-over unmute parameter #1985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me s well
/// <returns>A communications channel to a sound device running on Unix.</returns> | ||
public static SoundDevice Create(SoundConnectionSettings settings) => new UnixSoundDevice(settings); | ||
/// <remarks>Some device do not support to be unmuted, if you try so, it will raise an exception and dispose the device. In this case, you should set the unmute parameter to false</remarks> | ||
public static SoundDevice Create(SoundConnectionSettings settings, bool unmute = true) => new UnixSoundDevice(settings, unmute); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a binary breaking change against the previous version of the library, which is why the builds in Windows are failing. Could you please instead create a new constructor where the unmute
param is not defaulted? That way we won't have the breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, well done
Some device(e.g. the alsa softvol plugin) do not support to be unmuted, if you try so, it will raise an exception and dispose the device.
Microsoft Reviewers: Open in CodeFlow