Update Microsoft.Extensions.Logging to v7.0.0, drop netcoreap3.1 support #1990

pgrawehr · 2022-12-03T09:12:23Z

Fixes #1984

Updates Microsoft.Extensions.Logging and Microsoft.Extensions.Logging.Abstractions to v7.0.0. Since they officially no longer support netcoreapp3.1, that is dropped now, as discussed in #1984.

All tests are now by default built against .net6.0, some additionally against .net48 (to test netstandard2.0 support).

Microsoft Reviewers: Open in CodeFlow

Now only warns about untested netcoreapp3.1 compatibility

And remove explicit hints that make the tests optional, since most bindings will have some methods that are testable.

raffaeler

Not sure if the sendTohelix.proj, Iot.Device.Bindings.csproj and System.Device.Gpio.Tests.csproj can have the parametrized tfms.
Out of that, it looks great.

I don't get why the onewire ReadTemperatureAsync fails as it is fenced from netstandard2.0.

Causes a compatibility regression when a netcoreapp3.1 application now reverts to use the netstandard2.0 library.

(Another instance of the macos compiler failure that occurs if two projects share the same physical folder)

pgrawehr · 2022-12-04T14:36:00Z

Not sure if the sendTohelix.proj, Iot.Device.Bindings.csproj and System.Device.Gpio.Tests.csproj can have the parametrized tfms. Out of that, it looks great.

Appears to work. The helix tests don't work yet, but that's because it cannot find xunit-console.exe, or maybe even it sets up an incorrect command line. But I don't know the infrastructure there well enough to be able to fix this one.

I don't get why the onewire ReadTemperatureAsync fails as it is fenced from netstandard2.0.

There's an #ifdef !netstandard2.0 in the binding. The compatibility testing tests whether the new build is backwards compatible, which it is not for a netcoreapp3.1 assembly, because it now has to link against the netstandard-build, which does not have those methods.

raffaeler · 2022-12-04T14:54:56Z

There's an #ifdef !netstandard2.0 in the binding

I've seen that, that's why I commented that looked good to me.
I guess the rest of the work should be done with higher privileges in the repo.

pgrawehr · 2022-12-04T15:01:50Z

@joperezr Can you take a look at the helix build failures? It seems we must somehow choose a new path for the xunit-console runner, but I don't know how I can find that.

joperezr · 2022-12-05T20:54:55Z

eng/sendToHelix.proj

@@ -12,7 +12,7 @@

    <IncludeDotNetCli>true</IncludeDotNetCli>
    <DotNetCliPackageType>sdk</DotNetCliPackageType>
-    <DotNetCliVersion>3.1.405</DotNetCliVersion>
+    <DotNetCliVersion>6.0.400</DotNetCliVersion>


I don't think that you can make the changes to this file like you are doing here. This depends on on some Helix infrastructure, so we should make sure which version can be used.

This part appears to be working (see log from build), the problem is that it's not finding a matching xunit-console binary. And I don't know where that one is referenced (this project file only mentions the arguments to it, but not the binary itself, it seems)

joperezr · 2022-12-05T20:55:26Z

eng/Versions.props

@@ -12,11 +12,11 @@
    <SystemRuntimeWindowsRuntimePackageVersion>4.6.0</SystemRuntimeWindowsRuntimePackageVersion>
    <SystemManagementPackageVersion>5.0.0</SystemManagementPackageVersion>
    <SystemThreadingTasksExtensionsPackageVersion>4.5.4</SystemThreadingTasksExtensionsPackageVersion>
-    <SystemMemoryPackageVersion>4.5.4</SystemMemoryPackageVersion>
+    <SystemMemoryPackageVersion>4.5.5</SystemMemoryPackageVersion>


Is there a reason why we have to make these changes together with the nca3.1 changes? I think it would be better to isolate the two.

It's actually the other way round: The package updates require the nca3.1 changes, because the newer packages are not supported on nca3.1 any more.

It's probably possible to separate the two (and merge the 3.1 change first), if that's really required.

pgrawehr · 2022-12-24T15:40:53Z

/azp run dotnet.iot

azure-pipelines · 2022-12-24T15:41:03Z

Azure Pipelines successfully started running 1 pipeline(s).

pgrawehr · 2022-12-25T09:33:03Z

@MattGal Can you help here?

I have updated the tests to use .net6.0, which includes the helix tests as well. But unfortunately, something is missing (or incorrect) now. Running the tests results in this error (full build log here):

+ sudo -E /home/helixbot/work/B9EC0A33/p/dotnet-cli/dotnet /home/helixbot/work/B9EC0A33/p/xunit-runner/tools/net6.0/xunit.console.exe System.Device.Gpio.Tests.dll -nocolor -verbose -serialize -maxthreads 1 -notrait SkipOnTestRun=Unix -xml testResults.xml
....

  * You intended to execute a .NET program, but dotnet-/home/helixbot/work/B9EC0A33/p/xunit-runner/tools/net6.0

Apparently, the path /home/helixbot/work/B9EC0A33/p/xunit-runner/tools/net6.0/xunit.console.exe is wrong. Where should that be and how can it be changed? I can't seem to see that path in any of the build scripts.

MattGal · 2022-12-29T16:37:12Z

@MattGal Can you help here?

I have updated the tests to use .net6.0, which includes the helix tests as well. But unfortunately, something is missing (or incorrect) now. Running the tests results in this error (full build log here):
+ sudo -E /home/helixbot/work/B9EC0A33/p/dotnet-cli/dotnet /home/helixbot/work/B9EC0A33/p/xunit-runner/tools/net6.0/xunit.console.exe System.Device.Gpio.Tests.dll -nocolor -verbose -serialize -maxthreads 1 -notrait SkipOnTestRun=Unix -xml testResults.xml
....

  * You intended to execute a .NET program, but dotnet-/home/helixbot/work/B9EC0A33/p/xunit-runner/tools/net6.0
Apparently, the path /home/helixbot/work/B9EC0A33/p/xunit-runner/tools/net6.0/xunit.console.exe is wrong. Where should that be and how can it be changed? I can't seem to see that path in any of the build scripts.

Just got back from holiday time, I will take a look at this and let you know if I have any useful advice.

MattGal · 2022-12-29T20:42:07Z

@MattGal Can you help here?
I have updated the tests to use .net6.0, which includes the helix tests as well. But unfortunately, something is missing (or incorrect) now. Running the tests results in this error (full build log here):
+ sudo -E /home/helixbot/work/B9EC0A33/p/dotnet-cli/dotnet /home/helixbot/work/B9EC0A33/p/xunit-runner/tools/net6.0/xunit.console.exe System.Device.Gpio.Tests.dll -nocolor -verbose -serialize -maxthreads 1 -notrait SkipOnTestRun=Unix -xml testResults.xml
....

  * You intended to execute a .NET program, but dotnet-/home/helixbot/work/B9EC0A33/p/xunit-runner/tools/net6.0
Apparently, the path /home/helixbot/work/B9EC0A33/p/xunit-runner/tools/net6.0/xunit.console.exe is wrong. Where should that be and how can it be changed? I can't seem to see that path in any of the build scripts.
Just got back from holiday time, I will take a look at this and let you know if I have any useful advice.

OK so what's going on here is your choice of "runtimeTargetFramework" of net6.0, which I don't think is the right value.

The Arcade Helix SDK's support for XUnit tests is pretty simple; it includes the nupkg directly (it's just a zip after all) as a correlation payload, and then in the Arcade sources here you can see how it calculates where in this nupkg the xunit console runner lives.

Unpacking the raw XUnit runner package you'll see there just isn't a runtimeTargetFramework with that name, so the path it tries to construct based off your changes doesn't exist and you get the error you're noting.

I think just changing runtimeTargetFramework to netcoreapp2.0 should be all that's needed here. I'll leave a suggested change for that.

eng/sendToHelix.proj

Co-authored-by: Matt Galbraith <MattGal@users.noreply.github.com>

joperezr · 2023-01-05T16:33:55Z

/azp run dotnet.iot

azure-pipelines · 2023-01-05T16:34:05Z

Azure Pipelines successfully started running 1 pipeline(s).

joperezr · 2023-01-05T18:50:05Z

Looks like #1916 added some merge conflicts so we can't merge this as is any longer. @pgrawehr could you please resolve and merge?

joperezr

Other than the merge conflicts that need to be fixed, this looks good to me.

# Conflicts: # src/devices/Display/Display.sln

pgrawehr added 7 commits November 20, 2022 21:19

Update Microsoft.Extensions.Logging to v7.0.0

4f1e214

Fix nullability warnings

9e0bedd

Now only warns about untested netcoreapp3.1 compatibility

Start removing netcoreapp3.1 support

76f8032

Update template project

9b19856

And remove explicit hints that make the tests optional, since most bindings will have some methods that are testable.

Update TFM for tests to .NET 6.0

bcd31ab

Make test compile for .NET4.8

a5e003b

What version number do I need to use here?

46a79fc

raffaeler approved these changes Dec 4, 2022

View reviewed changes

Workaround for missing File.WriteAllTextAsync.

ef87e2a

Causes a compatibility regression when a netcoreapp3.1 application now reverts to use the netstandard2.0 library.

pgrawehr force-pushed the Logging-7.0 branch from a365592 to ef87e2a Compare December 4, 2022 13:14

Move samples to separate folder

47c16aa

(Another instance of the macos compiler failure that occurs if two projects share the same physical folder)

joperezr reviewed Dec 5, 2022

View reviewed changes

joperezr added the Priority:0 Work that we can't release without label Dec 8, 2022

MattGal reviewed Dec 29, 2022

View reviewed changes

eng/sendToHelix.proj Outdated Show resolved Hide resolved

Try with netcoreapp2.0

0b67265

Co-authored-by: Matt Galbraith <MattGal@users.noreply.github.com>

pgrawehr requested a review from joperezr December 30, 2022 12:47

joperezr approved these changes Jan 5, 2023

View reviewed changes

Merge remote-tracking branch 'remotes/dotnet/main' into Logging-7.0

02bef57

# Conflicts: # src/devices/Display/Display.sln

pgrawehr added 2 commits January 6, 2023 09:40

Fix build conflicts, move samples to separate folders

1e78ed5

Update CompatibilitySuppressions.xml

a43a47f

pgrawehr merged commit cc07422 into dotnet:main Jan 6, 2023

pgrawehr deleted the Logging-7.0 branch January 6, 2023 14:42

github-actions bot locked and limited conversation to collaborators Dec 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Microsoft.Extensions.Logging to v7.0.0, drop netcoreap3.1 support #1990

Update Microsoft.Extensions.Logging to v7.0.0, drop netcoreap3.1 support #1990

pgrawehr commented Dec 3, 2022 •

edited by ghost

Loading

raffaeler left a comment •

edited

Loading

pgrawehr commented Dec 4, 2022

raffaeler commented Dec 4, 2022

pgrawehr commented Dec 4, 2022

joperezr Dec 5, 2022

pgrawehr Dec 6, 2022

joperezr Dec 5, 2022

pgrawehr Dec 6, 2022

pgrawehr commented Dec 24, 2022

azure-pipelines bot commented Dec 24, 2022

pgrawehr commented Dec 25, 2022

MattGal commented Dec 29, 2022

MattGal commented Dec 29, 2022

joperezr commented Jan 5, 2023

azure-pipelines bot commented Jan 5, 2023

joperezr commented Jan 5, 2023

joperezr left a comment

Update Microsoft.Extensions.Logging to v7.0.0, drop netcoreap3.1 support #1990

Update Microsoft.Extensions.Logging to v7.0.0, drop netcoreap3.1 support #1990

Conversation

pgrawehr commented Dec 3, 2022 • edited by ghost Loading

Microsoft Reviewers: Open in CodeFlow

raffaeler left a comment • edited Loading

Choose a reason for hiding this comment

pgrawehr commented Dec 4, 2022

raffaeler commented Dec 4, 2022

pgrawehr commented Dec 4, 2022

joperezr Dec 5, 2022

Choose a reason for hiding this comment

pgrawehr Dec 6, 2022

Choose a reason for hiding this comment

joperezr Dec 5, 2022

Choose a reason for hiding this comment

pgrawehr Dec 6, 2022

Choose a reason for hiding this comment

pgrawehr commented Dec 24, 2022

azure-pipelines bot commented Dec 24, 2022

pgrawehr commented Dec 25, 2022

MattGal commented Dec 29, 2022

MattGal commented Dec 29, 2022

joperezr commented Jan 5, 2023

azure-pipelines bot commented Jan 5, 2023

joperezr commented Jan 5, 2023

joperezr left a comment

Choose a reason for hiding this comment

pgrawehr commented Dec 3, 2022 •

edited by ghost

Loading

raffaeler left a comment •

edited

Loading