-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add binding for generic HX711 (load cell amplifier and 24-Bit ADC Module) driver #1994
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this nice addition, couple of questions and some remarks on naming conventions mainly
@Ellerbach |
Please check the Markdown linter, I pointed the obvious, but you have some hidden ;-) Check as well while things are failing for the rest in the tests. Otherwise, all up, looks good to me. I'll have another look a bit later. |
I haven't more warning in my Markdown linter, but validation fail. What's wrong? I can't see pipeline details. Thanks for support. |
No worry, the other warning are the link checker which is far to be perfect (we will remove it from the pipeline). Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this nice addition, looks good to me. Let's wait for someone else to have a look.
@krwq there are still some pending points, if you give me an answer I'll see if I can correct the code so as to close the pr. Thank you very much. Happy Holidays! |
/azp run dotnet.iot |
Azure Pipelines successfully started running 1 pipeline(s). |
@dotnet-policy-service agree |
/azp run |
No commit pushedDate could be found for PR 1994 in repo dotnet/iot |
- Add Hx711 options - Add `SetCalibration` method - Fix weight reading process
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@matteo-tosi Thanks for this addition! |
Driver used by read weight of any load cell.
Microsoft Reviewers: Open in CodeFlow