FT232H: SetDataBitsLowByte requires value before direction (#1996) #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-device-bindings
Ellerbach
approved these changes
Dec 29, 2022
Glad to help! |
|
@krwq @pgrawehr @raffaeler @joperezr anyone to approve this one, so we can merge it quickly? :-) |
raffaeler
approved these changes
Dec 29, 2022
pgrawehr
approved these changes
Dec 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1996Reading more than 1 byte using FT232H I2C bus resulted in an unusable bus because the command used to set the GPIOs direction and values had the parameters appended in the wrong order. This PR fix the order. Tested in the same condition as described in #1996.
Microsoft Reviewers: Open in CodeFlow