Reverse byte order of ATQA calculated by ListenToIsoCard14443TypeA #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssue 2004) The two bytes of the ATQA need to be treated as a little-endian integer.
ghost
added
the
area-device-bindings
jdbruner
changed the title
Ellerbach
approved these changes
Jan 9, 2023
|
I have a couple of different Mifare Classic 1K cards (alas, they have no printed labels and I don't recall the brand). According to the NXP datasheet (MF1S50YYX_V1), depending upon the specific part, the expected ATQA values are one of 0x0044, 0x0004, 0x0042, and 0x0002. When I read these cards with an NFC app on my Android phone it tells me their ATQA is 0x0004.
Without this change the ATQA as a ushort was 0x0400. After applying the change, the reported ushort is 0x0004.
…--John
________________________________
From: Laurent Ellerbach ***@***.***>
Sent: Monday, January 9, 2023 10:44
To: dotnet/iot ***@***.***>
Cc: jdbruner ***@***.***>; Author ***@***.***>
Subject: Re: [dotnet/iot] Reverse byte order of ATQA calculated by ListenToIsoCard14443TypeA (PR #2005)
@Ellerbach approved this pull request.
Looks good to me. With which card have you tested it?
—
Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Fdotnet%2Fiot%2Fpull%2F2005%23pullrequestreview-1241016916&data=05%7C01%7C%7C7c08e5694cac457bc88d08daf271ad5c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638088867312996074%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3goTKFr6%2FPo3K41GTarYnHbw5F0YnL%2FC%2FNN%2Fn%2BURR%2BQ%3D&reserved=0>, or unsubscribe<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Fnotifications%2Funsubscribe-auth%2FABYCRIBBEK7ZXAY46WLWTRLWRRMBHANCNFSM6AAAAAATUVYLAM&data=05%7C01%7C%7C7c08e5694cac457bc88d08daf271ad5c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638088867312996074%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=9MN%2BqL2G91YQAu3skGAcqEHyZGmlSVU2oQuFsdO5v00%3D&reserved=0>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2004
The two bytes of the ATQA need to be treated as a little-endian integer.
Microsoft Reviewers: Open in CodeFlow