Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UnitsNet to V5.0 #2010

Merged
3 commits merged into from
Feb 9, 2023
Merged

Update UnitsNet to V5.0 #2010

3 commits merged into from
Feb 9, 2023

Conversation

pgrawehr
Copy link
Contributor

@pgrawehr pgrawehr commented Jan 14, 2023

Updates UnitsNet to V5.0.0-rc010, fixing all the compile breakages due to breaking changes.

@joperezr Can we upload this package to the internal server? It seems the build is failing with an unpatched nuget.config.

Microsoft Reviewers: Open in CodeFlow

NuGet.config Outdated Show resolved Hide resolved
@joperezr
Copy link
Member

Can we upload this package to the internal server?

We can, but should we instead wait for it to GA instead of uploading an RC?

@pgrawehr
Copy link
Contributor Author

Can we upload this package to the internal server?

We can, but should we instead wait for it to GA instead of uploading an RC?

Idealy yes, but I need to find out how long it will take for RC. There have only been minimal (non-breaking) changes recently, so I expect a release soon. I'll try to find out.

@pgrawehr
Copy link
Contributor Author

pgrawehr commented Feb 5, 2023

@joperezr V5.0.0 final is out and now included in the PR. Can you please upload it to the internal feed so that the build passes? Thank you.

@joperezr
Copy link
Member

joperezr commented Feb 9, 2023

You should now be able to consume 5.1.0 here

@joperezr joperezr added the Auto-Merge When added to a PR, it will be automatically merged after all checks pass. label Feb 9, 2023
@ghost
Copy link

ghost commented Feb 9, 2023

Hello @joperezr!

Because this pull request has the Auto-Merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 6ceb7de into dotnet:main Feb 9, 2023
@krwq krwq mentioned this pull request Mar 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Auto-Merge When added to a PR, it will be automatically merged after all checks pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants