Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Mifare Ultralight EV1 counters #2026

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Conversation

jdbruner
Copy link
Contributor

@jdbruner jdbruner commented Feb 4, 2023

Add serialization for UltralightCommand.IncreaseCounter (which previously threw NotImplementedException).
Add a new public function IncreaseCounter, corresponding to GetCounter
Fix an operator precedence error in GetCounter

Microsoft Reviewers: Open in CodeFlow

Add serialization for UltralightCommand.IncreaseCounter
Add a new public function IncreaseCounter
Fix operator precedence error in GetCounter
@ghost ghost added the area-device-bindings Device Bindings for audio, sensor, motor, and display hardware that can used with System.Device.Gpio label Feb 4, 2023
@dnfadmin
Copy link

dnfadmin commented Feb 4, 2023

CLA assistant check
All CLA requirements met.

Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition and adding this new scenario which I haven't been able to test when writing the initial implementation.

@Ellerbach Ellerbach merged commit 301f795 into dotnet:main Feb 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-device-bindings Device Bindings for audio, sensor, motor, and display hardware that can used with System.Device.Gpio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants