-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Board: Improve I²C device management to avoid null reference exceptions #2032
Commits on Feb 7, 2023
-
I2cBusExtensions.PerformBusScan() cleanup
Remove devices after creating them while scanning the I2C bus. Resolves dotnet#2031
Configuration menu - View commit details
-
Copy full SHA for 11b5d35 - Browse repository at this point
Copy the full SHA 11b5d35View commit details
Commits on Feb 9, 2023
-
Revert "I2cBusExtensions.PerformBusScan() cleanup"
This reverts commit 11b5d35.
Configuration menu - View commit details
-
Copy full SHA for 5d1f7e5 - Browse repository at this point
Copy the full SHA 5d1f7e5View commit details -
Ft232HI2c: dispose without nulling the I²C bus
see discussion in dotnet#2032 resolves dotnet#2031
Configuration menu - View commit details
-
Copy full SHA for a3d98bb - Browse repository at this point
Copy the full SHA a3d98bbView commit details -
Ft232HI2c: simplify code comment
This commit is also an opportunity to re-run tests in the CI pipeline
Configuration menu - View commit details
-
Copy full SHA for 85856b7 - Browse repository at this point
Copy the full SHA 85856b7View commit details -
This commit demonstrates how to scan the I2C bus for addresses devices acknowledge. Before the fix discussed in dotnet#2032, this scan would leave the i2c bus in a bad state such that reading/writing to devices after the scan would throw null reference exceptions.
Configuration menu - View commit details
-
Copy full SHA for 7b4f08e - Browse repository at this point
Copy the full SHA 7b4f08eView commit details -
Ft232HI2c: null settings in destructor
This reduces load on the garbage collector. Note that `_i2cBus` should not be set to null at this time, as per discussion in dotnet#2032
Configuration menu - View commit details
-
Copy full SHA for cb1c639 - Browse repository at this point
Copy the full SHA cb1c639View commit details
Commits on Feb 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7157c5b - Browse repository at this point
Copy the full SHA 7157c5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0432fe5 - Browse repository at this point
Copy the full SHA 0432fe5View commit details
Commits on Feb 12, 2023
-
Ft232HI2cBus: add/remove device NoCheck
adds CreateDeviceNoCheck() and RemoveDeviceNoCheck() to mimic behaviors found in UnixI2cBus.cs Also creates a new used address hash set when CreateDevice() is called (not when the bus is instantiated), consistent with how the Unix I2C bus does it https://github.com/dotnet/iot/blob/main/src/System.Device.Gpio/System/Device/I2c/UnixI2cBus.cs
Configuration menu - View commit details
-
Copy full SHA for a507d62 - Browse repository at this point
Copy the full SHA a507d62View commit details -
Ft232hI2cDevice: set bus to null in destructor
consistent with how the Unix I2C device class does it https://github.com/dotnet/iot/blob/main/src/System.Device.Gpio/System/Device/I2c/Devices/UnixI2cDevice.cs
Configuration menu - View commit details
-
Copy full SHA for 0f39615 - Browse repository at this point
Copy the full SHA 0f39615View commit details -
Ft232h sample: opening and closing i2c devices
currently demonstrates the issue described by dotnet#2031 and dotnet#2032
Configuration menu - View commit details
-
Copy full SHA for 72e2ea0 - Browse repository at this point
Copy the full SHA 72e2ea0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e35b187 - Browse repository at this point
Copy the full SHA e35b187View commit details -
ProtocolTests: repeat creation of the same I2C device
expected to fail with a null reference exception due to a bug described by dotnet#2031 and dotnet#2032
Configuration menu - View commit details
-
Copy full SHA for e38addd - Browse repository at this point
Copy the full SHA e38adddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d435a1 - Browse repository at this point
Copy the full SHA 7d435a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0abc40e - Browse repository at this point
Copy the full SHA 0abc40eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e4d18f - Browse repository at this point
Copy the full SHA 3e4d18fView commit details -
BoardTest: dispose and recreate I2C device
fails, demonstrating issue discussed in dotnet#2031 and dotnet#2032
Configuration menu - View commit details
-
Copy full SHA for 6cef0f2 - Browse repository at this point
Copy the full SHA 6cef0f2View commit details -
Revert "Ft232h sample: opening and closing i2c devices"
This reverts commit 72e2ea0.
Configuration menu - View commit details
-
Copy full SHA for ef2c62f - Browse repository at this point
Copy the full SHA ef2c62fView commit details -
disable Board I2cBusManager device caching
fixes issues described in dotnet#2031 and dotnet#2032
Configuration menu - View commit details
-
Copy full SHA for 4c679a0 - Browse repository at this point
Copy the full SHA 4c679a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dfa427 - Browse repository at this point
Copy the full SHA 3dfa427View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad7bc86 - Browse repository at this point
Copy the full SHA ad7bc86View commit details -
Ft232HI2c: inherit from I2cDevice
so Microsoft.NET.ApiCompat.ValidatePackage.targets will pass after 3dfa427
Configuration menu - View commit details
-
Copy full SHA for a1a30d3 - Browse repository at this point
Copy the full SHA a1a30d3View commit details
Commits on Feb 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c28125c - Browse repository at this point
Copy the full SHA c28125cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cb4e2c - Browse repository at this point
Copy the full SHA 8cb4e2cView commit details
Commits on Feb 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a22bd02 - Browse repository at this point
Copy the full SHA a22bd02View commit details