A set of minor fixes #2044
Merged
A set of minor fixes #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-device-bindings
Ellerbach
approved these changes
Feb 20, 2023
| { | ||
| _sequence = new List<byte>() | ||
| { | ||
| (byte)command | ||
| }; | ||
| } | ||
|
|
||
| internal FirmataCommandSequence(FirmataCommand command, int pin) | ||
| { | ||
| if (pin > 15) |
There was a problem hiding this comment.
Are all the boards with the same limit? If I'm using an ESP32 I can get more. So did I miss here?
There was a problem hiding this comment.
This is a limit of the command, not of the protocol or the board. There are some commands that have a one-byte shorthand form, but this form is limited to 15 pins, because the pin number is encoded in a nibble only. All such commands have a longer form as well, see the destinction below.
| int pwmMaxValue = _supportedPinConfigurations[pin].PwmResolutionBits; // This is 8 for most arduino boards | ||
| pwmMaxValue = (1 << pwmMaxValue) - 1; | ||
| int value = (int)Math.Max(0, Math.Min(dutyCycle * pwmMaxValue, pwmMaxValue)); | ||
|
|
||
| // At most 14 bits used? | ||
| if (((pwmMaxValue & 0x3FFF) == pwmMaxValue) && (pin <= 15)) |
There was a problem hiding this comment.
same here, why the 15 pins limits?
There was a problem hiding this comment.
See other comment: If the pin number is <=15, a shorthand form of the command can be used.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a set of minor fixes for problems found while using some bindings.
Microsoft Reviewers: Open in CodeFlow